fix: emit EIP-4361-compliant SIWX message for EVM in Reown Cloud Auth#5683
Open
rtomas wants to merge 1 commit into
Open
fix: emit EIP-4361-compliant SIWX message for EVM in Reown Cloud Auth#5683rtomas wants to merge 1 commit into
rtomas wants to merge 1 commit into
Conversation
Phantom (and other strict EIP-4361 wallets) rejected the Reown Cloud Auth sign-in message on EVM with "invalid formatting" and never showed the prompt. The message used the CAIP-2 chain id (`Chain ID: eip155:1`) instead of the decimal EIP-155 id (`Chain ID: 1`), and emitted a single blank line after the address instead of the two EIP-4361 requires for the empty statement block. ReownAuthenticationMessenger now emits the decimal chain id and the correct blank-line structure for the EVM (eip155) namespace only; non-EVM messages (Solana, Bitcoin, ...) are byte-for-byte unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 44a0239 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
Contributor
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=926 👉 Please review the visual changes in Chromatic and accept or reject them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
📍 Important: Merge after https://github.com/reown-com/web-monorepo/pull/2863
Phantom (and other strict EIP-4361 wallets) rejected the Reown Cloud Auth sign-in message on EVM with "The app's signature request cannot be shown due to invalid formatting" and never showed the prompt, because the message used the CAIP-2 chain id (
Chain ID: eip155:1) instead of the decimal EIP-155 id (Chain ID: 1) and emitted only one blank line after the address instead of the two EIP-4361 requires for the empty statement block.ReownAuthenticationMessengernow emits the decimal chain id and the correct blank-line structure, scoped to the EVM (eip155) namespace only — non-EVM messages (Solana, Bitcoin, ...) are byte-for-byte unchanged. The unit test expectation was updated accordingly and a changeset added. Note: the Reown Cloud Auth backend validates the message server-side, so it must accept the EIP-4361-compliant format (lands in lockstep).Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
N/A
Checklist
🤖 Generated with Claude Code