Skip to content

Commit e34419f

Browse files
committed
feat: allow js sdk start without sdk key or base url
1 parent a28f9d4 commit e34419f

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

packages/sdk/src/client.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,10 @@ function createClientCore<T extends object = Record<string, unknown>>(
9999
}
100100
}
101101

102-
function get<K extends keyof T>(configName: K, getConfigOptions: GetConfigOptions<T[K]> = {}): T[K] {
102+
function get<K extends keyof T>(
103+
configName: K,
104+
getConfigOptions: GetConfigOptions<T[K]> = {}
105+
): T[K] {
103106
const config = configs.get(String(configName));
104107

105108
if (config === undefined) {
@@ -395,8 +398,8 @@ async function createReplaneClientInternal<T extends object = Record<string, unk
395398
*/
396399
function toFinalOptions<T extends object>(defaults: ReplaneClientOptions<T>): ReplaneFinalOptions {
397400
return {
398-
sdkKey: defaults.sdkKey,
399-
baseUrl: defaults.baseUrl.replace(/\/+$/, ""),
401+
sdkKey: defaults.sdkKey ?? "",
402+
baseUrl: (defaults.baseUrl ?? "").replace(/\/+$/, ""),
400403
fetchFn:
401404
defaults.fetchFn ??
402405
// some browsers require binding the fetch function to window

0 commit comments

Comments
 (0)