chore: remove sub to all config changes

Author: tilyupo

packages/sdk/README.md

@@ -178,31 +178,14 @@ const maxConnections = replane.get("max-connections", { default: 10 });
 replane.disconnect();
 ```
 
-### `replane.subscribe(callback)` or `replane.subscribe(configName, callback)`
+### `replane.subscribe(configName, callback)`
 
-Subscribe to config changes and receive real-time updates when configs are modified.
-
-**Two overloads:**
-
-1. **Subscribe to all config changes:**
-
-   ```ts
-   const unsubscribe = replane.subscribe((config) => {
-     console.log(`Config ${config.name} changed to:`, config.value);
-   });
-   ```
-
-2. **Subscribe to a specific config:**
-   ```ts
-   const unsubscribe = replane.subscribe("billing-enabled", (config) => {
-     console.log(`billing-enabled changed to:`, config.value);
-   });
-   ```
+Subscribe to a specific config's changes and receive real-time updates when it is modified.
 
 Parameters:
 
-- `callback` (function) – Function called when any config changes. Receives an object with `{ name, value }`.
-- `configName` (K extends keyof T) – Optional. If provided, only changes to this specific config will trigger the callback.
+- `configName` (K extends keyof T) – The config to watch for changes.
+- `callback` (function) – Function called when the config changes. Receives an object with `{ name, value }`.
 
 Returns a function to unsubscribe from the config changes.
 
@@ -220,19 +203,13 @@ await replane.connect({
   baseUrl: "https://cloud.replane.dev", // or your self-hosted URL
 });
 
-// Subscribe to all config changes
-const unsubscribeAll = replane.subscribe((config) => {
-  console.log(`Config ${config.name} updated:`, config.value);
-});
-
 // Subscribe to a specific config
 const unsubscribeFeature = replane.subscribe("feature-flag", (config) => {
   console.log("Feature flag changed:", config.value);
   // config.value is typed as boolean
 });
 
 // Later: unsubscribe when done
-unsubscribeAll();
 unsubscribeFeature();
 
 // Clean up when done
@@ -450,30 +427,18 @@ await replane.connect({
   baseUrl: "https://replane.my-host.com",
 });
 
-// Subscribe to all config changes
-const unsubscribeAll = replane.subscribe((config) => {
-  console.log(`Config ${config.name} changed:`, config.value);
-
-  // React to specific config changes
-  if (config.name === "feature-flag") {
-    console.log("Feature flag updated:", config.value);
-  }
-});
-
-// Subscribe to a specific config only
+// Subscribe to specific configs
 const unsubscribeFeature = replane.subscribe("feature-flag", (config) => {
   console.log("Feature flag changed:", config.value);
   // config.value is automatically typed as boolean
 });
 
-// Subscribe to multiple specific configs
 const unsubscribeMaxUsers = replane.subscribe("max-users", (config) => {
   console.log("Max users changed:", config.value);
   // config.value is automatically typed as number
 });
 
 // Cleanup
-unsubscribeAll();
 unsubscribeFeature();
 unsubscribeMaxUsers();
 replane.disconnect();

packages/sdk/examples/browser/src/main.ts

@@ -143,15 +143,20 @@ async function main() {
     // Render initial config
     renderConfig(replane);
 
-    // Subscribe to all config changes
-    replane.subscribe((config) => {
+    // Subscribe to specific configs
+    replane.subscribe("feature-flags", (config) => {
       log(`Config "${config.name}" updated`);
       renderConfig(replane);
     });
 
-    // Subscribe to specific config
-    replane.subscribe("feature-flags", () => {
-      log("Feature flags changed!");
+    replane.subscribe("rate-limits", (config) => {
+      log(`Config "${config.name}" updated`);
+      renderConfig(replane);
+    });
+
+    replane.subscribe("maintenance-mode", (config) => {
+      log(`Config "${config.name}" updated`);
+      renderConfig(replane);
     });
 
     log("Subscribed to config updates");

packages/sdk/examples/bun/src/index.ts

@@ -84,31 +84,37 @@ async function main() {
   // Subscribe to config changes (real-time updates via SSE)
   console.log("\nSubscribing to config changes...");
 
-  const unsubscribeAll = replane.subscribe((config) => {
-    console.log(`[Update] Config "${config.name}" changed:`, config.value);
-  });
-
-  // Subscribe to a specific config
+  // Subscribe to specific configs
   const unsubscribeFeatures = replane.subscribe("feature-flags", (config) => {
     console.log("[Update] Feature flags changed:", config.value);
   });
 
+  const unsubscribeRateLimits = replane.subscribe("rate-limits", (config) => {
+    console.log("[Update] Rate limits changed:", config.value);
+  });
+
+  const unsubscribeMaintenance = replane.subscribe("maintenance-mode", (config) => {
+    console.log("[Update] Maintenance mode changed:", config.value);
+  });
+
   // Keep the process running to receive updates
   console.log("Listening for config updates. Press Ctrl+C to exit.\n");
 
   // Handle graceful shutdown
   process.on("SIGINT", () => {
     console.log("\nShutting down...");
-    unsubscribeAll();
     unsubscribeFeatures();
+    unsubscribeRateLimits();
+    unsubscribeMaintenance();
     replane.disconnect();
     process.exit(0);
   });
 
   process.on("SIGTERM", () => {
     console.log("\nShutting down...");
-    unsubscribeAll();
     unsubscribeFeatures();
+    unsubscribeRateLimits();
+    unsubscribeMaintenance();
     replane.disconnect();
     process.exit(0);
   });

packages/sdk/examples/deno/src/index.ts

@@ -84,23 +84,28 @@ async function main() {
   // Subscribe to config changes (real-time updates via SSE)
   console.log("\nSubscribing to config changes...");
 
-  const unsubscribeAll = replane.subscribe((config) => {
-    console.log(`[Update] Config "${config.name}" changed:`, config.value);
-  });
-
-  // Subscribe to a specific config
+  // Subscribe to specific configs
   const unsubscribeFeatures = replane.subscribe("feature-flags", (config) => {
     console.log("[Update] Feature flags changed:", config.value);
   });
 
+  const unsubscribeRateLimits = replane.subscribe("rate-limits", (config) => {
+    console.log("[Update] Rate limits changed:", config.value);
+  });
+
+  const unsubscribeMaintenance = replane.subscribe("maintenance-mode", (config) => {
+    console.log("[Update] Maintenance mode changed:", config.value);
+  });
+
   // Keep the process running to receive updates
   console.log("Listening for config updates. Press Ctrl+C to exit.\n");
 
   // Handle graceful shutdown
   Deno.addSignalListener("SIGINT", () => {
     console.log("\nShutting down...");
-    unsubscribeAll();
     unsubscribeFeatures();
+    unsubscribeRateLimits();
+    unsubscribeMaintenance();
     replane.disconnect();
     Deno.exit(0);
   });

packages/sdk/examples/node/src/index.ts

@@ -84,31 +84,37 @@ async function main() {
   // Subscribe to config changes (real-time updates via SSE)
   console.log("\nSubscribing to config changes...");
 
-  const unsubscribeAll = replane.subscribe((config) => {
-    console.log(`[Update] Config "${config.name}" changed:`, config.value);
-  });
-
-  // Subscribe to a specific config
+  // Subscribe to specific configs
   const unsubscribeFeatures = replane.subscribe("feature-flags", (config) => {
     console.log("[Update] Feature flags changed:", config.value);
   });
 
+  const unsubscribeRateLimits = replane.subscribe("rate-limits", (config) => {
+    console.log("[Update] Rate limits changed:", config.value);
+  });
+
+  const unsubscribeMaintenance = replane.subscribe("maintenance-mode", (config) => {
+    console.log("[Update] Maintenance mode changed:", config.value);
+  });
+
   // Keep the process running to receive updates
   console.log("Listening for config updates. Press Ctrl+C to exit.\n");
 
   // Handle graceful shutdown
   process.on("SIGINT", () => {
     console.log("\nShutting down...");
-    unsubscribeAll();
     unsubscribeFeatures();
+    unsubscribeRateLimits();
+    unsubscribeMaintenance();
     replane.disconnect();
     process.exit(0);
   });
 
   process.on("SIGTERM", () => {
     console.log("\nShutting down...");
-    unsubscribeAll();
     unsubscribeFeatures();
+    unsubscribeRateLimits();
+    unsubscribeMaintenance();
     replane.disconnect();
     process.exit(0);
   });

packages/sdk/src/client.ts

@@ -59,7 +59,6 @@ export class Replane<T extends object = Record<string, unknown>> {
   private logger: ReplaneLogger;
   private storage: ReplaneRemoteStorage | null = null;
   private configSubscriptions = new Map<keyof T, Set<(config: MapConfig<T>) => void>>();
-  private clientSubscriptions = new Set<(config: MapConfig<T>) => void>();
 
   /**
    * Create a new Replane client.
@@ -215,24 +214,6 @@ export class Replane<T extends object = Record<string, unknown>> {
     }
   }
 
-  /**
-   * Subscribe to config changes.
-   *
-   * @param callback - Function called when any config changes
-   * @returns Unsubscribe function
-   *
-   * @example
-   * ```typescript
-   * const unsubscribe = client.subscribe((change) => {
-   *   console.log(`Config ${change.name} changed to ${change.value}`);
-   * });
-   *
-   * // Later: stop listening
-   * unsubscribe();
-   * ```
-   */
-  subscribe(callback: (config: MapConfig<T>) => void): () => void;
-
   /**
    * Subscribe to a specific config's changes.
    *
@@ -250,46 +231,20 @@ export class Replane<T extends object = Record<string, unknown>> {
   subscribe<K extends keyof T>(
     configName: K,
     callback: (config: { name: K; value: T[K] }) => void
-  ): () => void;
-
-  subscribe<K extends keyof T>(
-    callbackOrConfigName: K | ((config: MapConfig<T>) => void),
-    callbackOrUndefined?: (config: { name: K; value: T[K] }) => void
   ): () => void {
-    let configName: keyof T | undefined = undefined;
-    let callback: (config: MapConfig<T>) => void;
-
-    if (typeof callbackOrConfigName === "function") {
-      callback = callbackOrConfigName;
-    } else {
-      configName = callbackOrConfigName as keyof T;
-      if (callbackOrUndefined === undefined) {
-        throw new Error("callback is required when config name is provided");
-      }
-      // Type assertion is safe: MapConfig<T> is a union that includes { name: K, value: T[K] }
-      callback = callbackOrUndefined as (config: MapConfig<T>) => void;
-    }
-
     // Wrap the callback to ensure that we have a unique reference
-    const originalCallback = callback;
-    callback = (...args: Parameters<typeof callback>) => {
-      originalCallback(...args);
+    // Type assertion is safe: MapConfig<T> is a union that includes { name: K, value: T[K] }
+    const wrappedCallback = (config: MapConfig<T>) => {
+      callback(config as { name: K; value: T[K] });
     };
 
-    if (configName === undefined) {
-      this.clientSubscriptions.add(callback);
-      return () => {
-        this.clientSubscriptions.delete(callback);
-      };
-    }
-
     if (!this.configSubscriptions.has(configName)) {
       this.configSubscriptions.set(configName, new Set());
     }
-    this.configSubscriptions.get(configName)!.add(callback);
+    this.configSubscriptions.get(configName)!.add(wrappedCallback);
 
     return () => {
-      this.configSubscriptions.get(configName)?.delete(callback);
+      this.configSubscriptions.get(configName)?.delete(wrappedCallback);
       if (this.configSubscriptions.get(configName)?.size === 0) {
         this.configSubscriptions.delete(configName);
       }
@@ -378,9 +333,6 @@ export class Replane<T extends object = Record<string, unknown>> {
 
       const change = { name: config.name as keyof T, value: config.value as T[keyof T] };
 
-      for (const callback of this.clientSubscriptions) {
-        callback(change);
-      }
       for (const callback of this.configSubscriptions.get(config.name as keyof T) ?? []) {
         callback(change);
       }