From 587db15552c8152d3daceb11125b996861fecc80 Mon Sep 17 00:00:00 2001 From: Michael Ward Date: Tue, 24 Feb 2026 10:28:55 -0500 Subject: [PATCH 1/2] fix mac arm64 e2e test expectations --- packages/e2e-tests/tests/highlighter.test.ts | 2 +- packages/e2e-tests/tests/object_preview-04.test.ts | 2 +- packages/e2e-tests/tests/stepping-06.test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/e2e-tests/tests/highlighter.test.ts b/packages/e2e-tests/tests/highlighter.test.ts index 80df6cdbc32..0a30636001b 100644 --- a/packages/e2e-tests/tests/highlighter.test.ts +++ b/packages/e2e-tests/tests/highlighter.test.ts @@ -36,6 +36,6 @@ test("highlighter: element highlighter works everywhere", async ({ // at all (is the box even visible on screen), and 2) is it // over the iframe element we're trying to highlight. // These coordinates visually match the location of the iframe. - const pathDefinitionToCompare = `M8,44 L312,44 L312,198 L8,198`; + const pathDefinitionToCompare = `M8,45 L312,45 L312,199 L8,199`; expect(normalizedPathDefinition).toBe(pathDefinitionToCompare); }); diff --git a/packages/e2e-tests/tests/object_preview-04.test.ts b/packages/e2e-tests/tests/object_preview-04.test.ts index ad84b570c42..a7c09d16586 100644 --- a/packages/e2e-tests/tests/object_preview-04.test.ts +++ b/packages/e2e-tests/tests/object_preview-04.test.ts @@ -23,7 +23,7 @@ test(`object_preview-04: Test scope mapping and switching between generated/orig url: "bundle_input.js", }); - await warpToMessage(page, "20", 15); + await warpToMessage(page, "20", 19); await expandAllScopesBlocks(page); await waitForScopeValue(page, "bar", "ƒo()"); diff --git a/packages/e2e-tests/tests/stepping-06.test.ts b/packages/e2e-tests/tests/stepping-06.test.ts index a01c13edb00..1473918c1f5 100644 --- a/packages/e2e-tests/tests/stepping-06.test.ts +++ b/packages/e2e-tests/tests/stepping-06.test.ts @@ -33,7 +33,7 @@ test(`stepping-06: Test stepping in async frames and async call stacks`, async ( await waitForScopeValue(page, "n", "4"); await waitForFrameTimeline(page, "85%"); await selectFrame(page, 3); - await waitForFrameTimeline(page, "83%"); + await waitForFrameTimeline(page, "71%"); await selectFrame(page, 4); await waitForFrameTimeline(page, "0%"); await selectFrame(page, 0); From 35c5a99bc4df698d3a56fe3bd2452b9e2848b3f4 Mon Sep 17 00:00:00 2001 From: Michael Ward Date: Tue, 24 Feb 2026 12:13:04 -0500 Subject: [PATCH 2/2] add --no-sandbox for chromium in containers --- packages/e2e-tests/playwright.config.ts | 1 + packages/playwright-recorder/src/index.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/e2e-tests/playwright.config.ts b/packages/e2e-tests/playwright.config.ts index cc6492b6b5a..39b0b780ed1 100644 --- a/packages/e2e-tests/playwright.config.ts +++ b/packages/e2e-tests/playwright.config.ts @@ -36,6 +36,7 @@ const config: PlaywrightTestConfig = { use: { launchOptions: { slowMo: SLOW_MO ? parseInt(SLOW_MO, 10) : 0, + args: ["--no-sandbox", "--disable-setuid-sandbox"], }, viewport: { width: 1280, diff --git a/packages/playwright-recorder/src/index.ts b/packages/playwright-recorder/src/index.ts index 51145e116d0..0f1e3b250b9 100644 --- a/packages/playwright-recorder/src/index.ts +++ b/packages/playwright-recorder/src/index.ts @@ -150,6 +150,7 @@ export async function recordPlaywright( let executablePath = config.browserPath ?? getExecutablePath() ?? undefined; const browserServer = await chromium.launchServer({ + args: ["--no-sandbox", "--disable-setuid-sandbox"], env: { ...process.env, RECORD_ALL_CONTENT: "1",