This repository was archived by the owner on Apr 15, 2026. It is now read-only.
Correct a spurious slot release#220
Merged
Merged
Conversation
The slot release was incorrect and was run outside of the manager.predict function meaning we effectively had more slots than expected. This change eliminates the added .releaseSlot() call in the wrong method.
tempusfrangit
requested review from
Copilot
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slot release was incorrect and was run outside of the manager.predict function meaning we effectively had more slots than expected.
This change eliminates the added .releaseSlot() call in the wrong method.