Support os.PathLike output from models#2388
Merged
Merged
Conversation
This commit updates two pieces of our file handling code to work
with `os.PathLike` objects.
1. When transforming the output into a data-structure suitable for
encoding in `make_encodable` we convert the `PathLike` into a
`pathlib.Path` instance.
2. When reading the file data from disk in `upload_files` we use
`open()` instead of `Path.open()`.
This provides broader support for path-like objects, particularly
the new replicate-python client which will return path-like objects
from the new `use()` helper.
8W9aG
approved these changes
Jun 3, 2025
8W9aG
left a comment
8W9aG
left a comment
Contributor
There was a problem hiding this comment.
Great change! It seems that this was introduced in python 3.6 so should be well within our compatibility window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates two pieces of our file handling code to work with
os.PathLikeobjects.make_encodablewe convert thePathLikeinto apathlib.Pathinstance.upload_fileswe useopen()instead ofPath.open().This provides broader support for path-like objects, particularly the new replicate-python client which will return path-like objects from the new
use()helper.