feat: cog playground#3115
Conversation
* feat: add Go playground server * fix: strip protocol-relative playground redirects * fix: strip all playground proxy redirects
|
I found one critical issue in this PR:
The Fix: // pkg/cli/root.go
rootCmd.AddCommand(
newBuildCommand(),
newDebugCommand(),
newDoctorCommand(),
newInitCommand(),
newLoginCommand(),
newRunCommand(),
newPredictCommand(),
newPushCommand(),
newExecCommand(),
newServeCommand(),
newTrainCommand(),
newWeightsCommand(),
newPlaygroundCommand(), // <-- add this
) |
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a I found one critical issue that prevents the command from being usable at all:
The command is fully implemented in Posted the fix as a PR comment: #3115 (comment) |
|
I found one critical issue in this PR:
The Fix: // pkg/cli/root.go
rootCmd.AddCommand(
newBuildCommand(),
newDebugCommand(),
newDoctorCommand(),
newInitCommand(),
newLoginCommand(),
newRunCommand(),
newPredictCommand(),
newPushCommand(),
newExecCommand(),
newServeCommand(),
newTrainCommand(),
newWeightsCommand(),
newPlaygroundCommand(), // <-- add this
) |
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a I found one critical issue that prevents the command from being usable at all:
The command is fully implemented in Posted the fix as a PR comment: #3115 (comment) |
* feat(playground): add Cog API client * fix(playground): harden local file and SSE cleanup * test(playground): pass SSE iterator return value * test(playground): mock SSE cancellation failure * style(playground): format SSE cleanup test * test(playground): use a real SSE frame * fix(playground): validate API responses
|
Im Bonk, and Ive done a quick review of your PR. This PR introduces a However, the same critical issue flagged in previous reviews is still unfixed and prevents the command from being usable at all:
The command is fully implemented in Fix: // pkg/cli/root.go
rootCmd.AddCommand(
newBuildCommand(),
newDebugCommand(),
newDoctorCommand(),
newInitCommand(),
newLoginCommand(),
newRunCommand(),
newPredictCommand(),
newPushCommand(),
newExecCommand(),
newServeCommand(),
newTrainCommand(),
newWeightsCommand(),
newPlaygroundCommand(), // <-- add this
) |
|
I'm Bonk, and I've done a quick review of your PR. This PR introduces a However, the same critical issue flagged in previous reviews is still unfixed and prevents the command from being usable at all:
The command is fully implemented in Fix: // pkg/cli/root.go
rootCmd.AddCommand(
newBuildCommand(),
newDebugCommand(),
newDoctorCommand(),
newInitCommand(),
newLoginCommand(),
newRunCommand(),
newPredictCommand(),
newPushCommand(),
newExecCommand(),
newServeCommand(),
newTrainCommand(),
newWeightsCommand(),
newPlaygroundCommand(), // <-- add this
)Posted the fix as a PR comment: #3115 (comment) |
|
I found one critical issue in this PR:
The Fix: // pkg/cli/root.go
rootCmd.AddCommand(
newBuildCommand(),
newDebugCommand(),
newDoctorCommand(),
newInitCommand(),
newLoginCommand(),
newRunCommand(),
newPredictCommand(),
newPushCommand(),
newExecCommand(),
newServeCommand(),
newTrainCommand(),
newWeightsCommand(),
newPlaygroundCommand(), // <-- add this
) |
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a However, the same critical issue flagged in previous reviews is still unfixed and prevents the command from being usable at all:
The command is fully implemented in Posted the fix as a PR comment: #3115 (comment) |
* feat(playground): add input controls and validation * fix(playground): reset input state on unmount
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a However, the same critical issue flagged in previous reviews is still unfixed and prevents the command from being usable at all:
The command is fully implemented in Fix: // pkg/cli/root.go
rootCmd.AddCommand(
newBuildCommand(),
newDebugCommand(),
newDoctorCommand(),
newInitCommand(),
newLoginCommand(),
newRunCommand(),
newPredictCommand(),
newPushCommand(),
newExecCommand(),
newServeCommand(),
newTrainCommand(),
newWeightsCommand(),
newPlaygroundCommand(), // <-- add this
) |
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a However, the same critical issue flagged in previous reviews is still unfixed and prevents the command from being usable at all:
The command is fully implemented in Posted the fix as a PR comment: #3115 (comment) |
Cog Playground
A browser-based playground UI for testing Cog models locally, served by a Go HTTP server embedded in the Cog CLI.
Stack PRs