Skip to content

feat(ec): lint helm charts declared in EC Config extensions#247

Merged
emosbaugh merged 1 commit into
mainfrom
emosbaugh/20260506/ec-config-helmchart-validation
May 8, 2026
Merged

feat(ec): lint helm charts declared in EC Config extensions#247
emosbaugh merged 1 commit into
mainfrom
emosbaugh/20260506/ec-config-helmchart-validation

Conversation

@emosbaugh
Copy link
Copy Markdown
Contributor

Summary

Extends the existing helm chart archive validation to also recognize helm charts declared in EmbeddedCluster Config manifests (extensions.helmCharts[].chart.name / chartVersion).

Changes

  • Introduced a chartIdentity interface so the archive-matching logic works for both:
    • kots.io/v1beta1 HelmChart custom resources
    • embeddedcluster.replicated.com/v1beta1 Config with spec.extensions.helmCharts
  • Added findAllECConfigHelmCharts() to walk EC Config manifests and extract chart name/version pairs.
  • Updated archiveForHelmChartExists() and helmChartForArchiveExists() to accept the new interface.
  • Added unit tests in pkg/kots/lint_test.go and integration tests in test/integration/integration_test.go covering:
    • EC Config helm chart with matching archive (no errors)
    • EC Config helm chart missing archive (helm-archive-missing)
    • Archive present with only EC Config entry (no helm-chart-missing)

@emosbaugh emosbaugh added the type::feature New feature or request label May 7, 2026
@emosbaugh
Copy link
Copy Markdown
Contributor Author

[sc-137591]

@emosbaugh emosbaugh merged commit f141b11 into main May 8, 2026
6 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/20260506/ec-config-helmchart-validation branch May 8, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type::feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants