Skip to content

Commit 64d366b

Browse files
kriscolemanclaude
andcommitted
chore(security): replace TLS cert/key PEM placeholders with obvious placeholders
The mlflow chart and the self-signed-vs-user-provided-tls pattern shipped example TLS values as empty PEM blocks: cert: | -----BEGIN CERTIFICATE----- -----END CERTIFICATE----- key: | -----BEGIN PRIVATE KEY----- -----END PRIVATE KEY----- GitHub secret scanning flags these (generic private key) even though they're empty, which clutters the security reports and makes audits noisier. Replace them with explicit, obviously-fake placeholders (REPLACE_WITH_YOUR_PEM_ENCODED_TLS_CERTIFICATE / ..._PRIVATE_KEY) so there are no PEM markers left to flag, it's unmistakable that nothing real is committed, and it's clear a real value must be supplied. Regenerated the mlflow helm-docs README table to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 7cf8422 commit 64d366b

3 files changed

Lines changed: 12 additions & 14 deletions

File tree

applications/mlflow/charts/mlflow/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,7 @@ When making changes to the MLflow Helm chart, corresponding updates may be neede
835835
| mlflow.image.repository | string | `"mlflow/mlflow"` | Image repository |
836836
| mlflow.image.tag | string | `"v3.3.2"` | Image tag |
837837
| mlflow.imagePullSecets | list | `[]` | Image pull secrets |
838-
| mlflow.ingress | object | `{"annotations":{},"className":"nginx","enabled":false,"extraHosts":[],"extraPaths":[],"extraRules":[],"extraTls":[],"hostname":"chart-example.local","path":"/","pathType":"ImplementationSpecific","tls":{"cert":"-----BEGIN CERTIFICATE-----\n-----END CERTIFICATE-----\n","enabled":false,"genSelfSignedCert":false,"key":"-----BEGIN PRIVATE KEY-----\n-----END PRIVATE KEY-----\n"}}` | Mlflow Ingress configuration [[ref]](https://kubernetes.io/docs/concepts/services-networking/ingress/) |
838+
| mlflow.ingress | object | `{"annotations":{},"className":"nginx","enabled":false,"extraHosts":[],"extraPaths":[],"extraRules":[],"extraTls":[],"hostname":"chart-example.local","path":"/","pathType":"ImplementationSpecific","tls":{"cert":"REPLACE_WITH_YOUR_PEM_ENCODED_TLS_CERTIFICATE","enabled":false,"genSelfSignedCert":false,"key":"REPLACE_WITH_YOUR_PEM_ENCODED_TLS_PRIVATE_KEY"}}` | Mlflow Ingress configuration [[ref]](https://kubernetes.io/docs/concepts/services-networking/ingress/) |
839839
| mlflow.ingress.annotations | object | `{}` | Annotations to add to the ingress |
840840
| mlflow.ingress.className | string | `"nginx"` | Ingress class name |
841841
| mlflow.ingress.enabled | bool | `false` | Specifies whether a ingress should be created |
@@ -846,7 +846,7 @@ When making changes to the MLflow Helm chart, corresponding updates may be neede
846846
| mlflow.ingress.hostname | string | `"chart-example.local"` | Ingress hostname |
847847
| mlflow.ingress.path | string | `"/"` | Ingress path |
848848
| mlflow.ingress.pathType | string | `"ImplementationSpecific"` | Ingress path type |
849-
| mlflow.ingress.tls | object | `{"cert":"-----BEGIN CERTIFICATE-----\n-----END CERTIFICATE-----\n","enabled":false,"genSelfSignedCert":false,"key":"-----BEGIN PRIVATE KEY-----\n-----END PRIVATE KEY-----\n"}` | Ingress TLS configuration |
849+
| mlflow.ingress.tls | object | `{"cert":"REPLACE_WITH_YOUR_PEM_ENCODED_TLS_CERTIFICATE","enabled":false,"genSelfSignedCert":false,"key":"REPLACE_WITH_YOUR_PEM_ENCODED_TLS_PRIVATE_KEY"}` | Ingress TLS configuration |
850850
| mlflow.ingress.tls.enabled | bool | `false` | Specifies whether to enable TLS |
851851
| mlflow.ingress.tls.genSelfSignedCert | bool | `false` | Specifies whether to generate self-signed certificate |
852852
| mlflow.labels | object | `{}` | Labels to add to the mlflow deployment |

applications/mlflow/charts/mlflow/values.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,12 +220,12 @@ mlflow:
220220
enabled: false
221221
# -- Specifies whether to generate self-signed certificate
222222
genSelfSignedCert: false
223-
cert: |
224-
-----BEGIN CERTIFICATE-----
225-
-----END CERTIFICATE-----
226-
key: |
227-
-----BEGIN PRIVATE KEY-----
228-
-----END PRIVATE KEY-----
223+
# -- PEM-encoded TLS certificate. Replace the placeholder with your real
224+
# certificate (or set genSelfSignedCert: true to generate one).
225+
cert: "REPLACE_WITH_YOUR_PEM_ENCODED_TLS_CERTIFICATE"
226+
# -- PEM-encoded TLS private key. Replace the placeholder with your real key
227+
# (or set genSelfSignedCert: true to generate one).
228+
key: "REPLACE_WITH_YOUR_PEM_ENCODED_TLS_PRIVATE_KEY"
229229
# -- Extra hosts to configure for the ingress object
230230
extraHosts: []
231231
# -- Extra paths to configure for the ingress object

patterns/self-signed-vs-user-provided-tls/README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,10 @@ ingress:
1414
tls:
1515
enabled: true
1616
genSelfSignedCert: true
17-
cert: |
18-
-----BEGIN CERTIFICATE-----
19-
-----END CERTIFICATE-----
20-
key: |
21-
-----BEGIN PRIVATE KEY-----
22-
-----END PRIVATE KEY-----
17+
# Replace the placeholders with your real PEM-encoded cert/key, or set
18+
# genSelfSignedCert: true to have them generated and omit these.
19+
cert: "REPLACE_WITH_YOUR_PEM_ENCODED_TLS_CERTIFICATE"
20+
key: "REPLACE_WITH_YOUR_PEM_ENCODED_TLS_PRIVATE_KEY"
2321
```
2422
2523
2. Add a tls secret to your chart and implement the templating to conditionally choose between user-provided and self-signed

0 commit comments

Comments
 (0)