make appSlug optional for list customers (#69)

* make appSlug optional for list customers

* prettier

Author: xavpaice

src/customers.spec.ts

@@ -225,4 +225,45 @@ describe("List Customers By Name", () => {
     expect(customers[100].customerId).toEqual("customer-101");
     expect(customers[149].customerId).toEqual("customer-150");
   });
+
+  it("should search across all apps when appSlug is undefined", async () => {
+    const customersResponse = {
+      data: [
+        { id: "customer-1", name: "Test Customer", app_name: "App 1" },
+        { id: "customer-2", name: "Test Customer Two", app_name: "App 2" },
+        { id: "customer-3", name: "Test Customer Three", app_name: "App 3" }
+      ],
+      total_count: 3
+    };
+
+    // When appSlug is undefined, we should NOT call the /apps endpoint
+    // Just set up the search endpoint response
+    await mockServer.forPost("/customers/search").thenReply(200, JSON.stringify(customersResponse));
+
+    const customers: CustomerSummary[] = await listCustomersByName(apiClient, undefined, "Test Customer");
+    expect(customers).toHaveLength(3);
+    expect(customers[0].name).toEqual("Test Customer");
+    expect(customers[1].name).toEqual("Test Customer Two");
+    expect(customers[2].name).toEqual("Test Customer Three");
+  });
+
+  it("should include app_id when appSlug is provided", async () => {
+    const appId = "test-app-123";
+    const appSlug = "test-app";
+    const expectedApplications = {
+      apps: [{ id: appId, name: "Test App", slug: appSlug }]
+    };
+    const customersResponse = {
+      data: [{ id: "customer-1", name: "Test Customer" }],
+      total_count: 1
+    };
+
+    // When appSlug is provided, we should call /apps first, then search
+    await mockServer.forGet("/apps").thenReply(200, JSON.stringify(expectedApplications));
+    await mockServer.forPost("/customers/search").thenReply(200, JSON.stringify(customersResponse));
+
+    const customers: CustomerSummary[] = await listCustomersByName(apiClient, appSlug, "Test Customer");
+    expect(customers).toHaveLength(1);
+    expect(customers[0].name).toEqual("Test Customer");
+  });
 });

src/customers.ts

@@ -157,11 +157,14 @@ export async function getUsedKubernetesDistributions(vendorPortalApi: VendorPort
   return kubernetesDistributions;
 }
 
-export async function listCustomersByName(vendorPortalApi: VendorPortalApi, appSlug: string, customerName: string): Promise<CustomerSummary[]> {
+export async function listCustomersByName(vendorPortalApi: VendorPortalApi, appSlug: string | undefined, customerName: string): Promise<CustomerSummary[]> {
   const http = await vendorPortalApi.client();
 
-  // Get the app ID from the app slug to filter results
-  const app = await getApplicationDetails(vendorPortalApi, appSlug);
+  // Get the app ID from the app slug to filter results (if appSlug is provided)
+  let app: any;
+  if (appSlug) {
+    app = await getApplicationDetails(vendorPortalApi, appSlug);
+  }
 
   // Use the searchTeamCustomers endpoint to search for customers by name and app
   const searchCustomersUri = `${vendorPortalApi.endpoint}/customers/search`;
@@ -172,7 +175,7 @@ export async function listCustomersByName(vendorPortalApi: VendorPortalApi, appS
   let hasMorePages = true;
 
   while (hasMorePages) {
-    const requestBody = {
+    const requestBody: any = {
       include_paid: true,
       include_inactive: true,
       include_dev: true,
@@ -182,11 +185,15 @@ export async function listCustomersByName(vendorPortalApi: VendorPortalApi, appS
       include_test: true,
       include_trial: true,
       query: `name:${customerName}`,
-      app_id: app.id,
       offset: offset,
       page_size: pageSize
     };
 
+    // Only add app_id if appSlug was provided
+    if (app) {
+      requestBody.app_id = app.id;
+    }
+
     const searchCustomersRes = await http.post(searchCustomersUri, JSON.stringify(requestBody));
     if (searchCustomersRes.message.statusCode != 200) {
       let body = "";