fix: resolve critical and high severity npm vulnerabilities#101
Merged
aa-replicated merged 2 commits intomainfrom Apr 14, 2026
Merged
fix: resolve critical and high severity npm vulnerabilities#101aa-replicated merged 2 commits intomainfrom
aa-replicated merged 2 commits intomainfrom
Conversation
Update indirect dependencies via npm audit fix to address: - axios <=1.14.0: critical SSRF via NO_PROXY bypass and header injection (GHSA-3p68-rc4w-qgx5, GHSA-fvcv-3m26-pcqx) - handlebars <=4.7.8: critical/high JS injection and prototype pollution (multiple CVEs) - basic-ftp <=5.2.1: high CRLF injection / FTP command injection (GHSA-6v7q-wjvx-w8wg, GHSA-chqc-8p9q-pq6q) - lodash <=4.17.23: high code injection and prototype pollution (GHSA-r5fr-rjxr-66jc, GHSA-f23m-r3pf-42rh) - path-to-regexp 8.0.0-8.3.0: high ReDoS (GHSA-j3q9-mxjg-w52f, GHSA-27v5-c462-wpq7) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fail() was removed in Jest 27+; replace with throw so errors surface correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
was looking to add axios vuln, need to redo it. |
Contributor
Author
|
OK, 1.15.0 is reported as safe and fixes the CRIT. re-opening. |
jdewinne
reviewed
Apr 14, 2026
| }) | ||
| .catch(err => { | ||
| fail(err); | ||
| throw err; |
Member
There was a problem hiding this comment.
Any reason for changing fail to throw?
Contributor
Author
There was a problem hiding this comment.
I had tests failing and claude found that it was because of a newer jest version. but now I don't see why there was a newer version, maybe that was a consequence of my environment. I'll look into it.
jdewinne
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.jsonvianpm audit fixto resolve 6 open Dependabot vulnerabilities (2 critical, 3 high, 1 moderate)package.json— all fixes were to indirect/transitive dependenciesVulnerabilities Fixed
axios≤1.14.0handlebars≤4.7.8basic-ftp≤5.2.1lodash≤4.17.23path-to-regexp8.0.0–8.3.0brace-expansionThese are all devDependencies (via
@pact-foundation/pact,ts-jest,mockttp,get-uri) and do not affect published library consumers.Test plan
npm auditreports 0 vulnerabilities after fixnpm test)🤖 Generated with Claude Code