fix(cli): send JSON struct for enterprise portal status update#714
Draft
kriscoleman wants to merge 2 commits intomainfrom
Draft
fix(cli): send JSON struct for enterprise portal status update#714kriscoleman wants to merge 2 commits intomainfrom
kriscoleman wants to merge 2 commits intomainfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Shortcut Story
sc-136041
Summary
Fixes the
replicated enterprise-portal status updatecommand so that it sends a proper JSON object ({\"status\":\"...\"}) instead of a bare JSON string, which was causing the API to return a 400 error.Also updates the CLI help text to enumerate the valid statuses (
active,inactive,pending) instead of the vague "any other valid status" wording.Changes
UpdateEnterprisePortalStatusinpkg/kotsclient/enterprise-portal.goto construct and send anUpdateEnterprisePortalStatusRequeststruct.UpdateEnterprisePortalStatusRequeststruct with astatusJSON field.pkg/kotsclient/enterprise-portal_test.gowith unit tests covering all enterprise portal client methods.--helptext and--statusflag description incli/cmd/enterpriseportal_status_update.goto list valid statuses.UAT
go test ./pkg/kotsclient/... -run TestEnterprisePortalClient -vgo build ./cli/...go run ./cli enterprise-portal status update --helpreplicated enterprise-portal status update --status inactiveagainst a valid app and confirm it succeeds without a 400 error.