Skip to content

Commit 34edbba

Browse files
committed
Fix tests
1 parent 63ed3e6 commit 34edbba

2 files changed

Lines changed: 14 additions & 17 deletions

File tree

pytest_reportportal/plugin.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@
4747

4848
LOGGER: Logger = logging.getLogger(__name__)
4949

50+
MANDATORY_PARAMETER_MISSED_PATTERN: str = (
51+
"One of the following mandatory parameters is unset: " + "rp_project: {}, rp_endpoint: {}"
52+
)
53+
5054
FAILED_LAUNCH_WAIT: str = (
5155
"Failed to initialize reportportal-client service. "
5256
+ "Waiting for Launch start timed out. "
@@ -194,6 +198,13 @@ def pytest_configure(config) -> None:
194198
LOGGER.debug("Disabling reporting to RP.")
195199
return
196200

201+
cond = (agent_config.rp_project, agent_config.rp_endpoint)
202+
config._rp_enabled = all(cond)
203+
if not config._rp_enabled:
204+
LOGGER.debug(MANDATORY_PARAMETER_MISSED_PATTERN.format(*cond))
205+
LOGGER.debug("Disabling reporting to RP.")
206+
return
207+
197208
config._reporter_config = agent_config
198209

199210
if is_control(config):

tests/unit/test_plugin.py

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,7 @@ def test_pytest_configure_misssing_rp_endpoint(mocked_log, mocked_config):
134134
assert mocked_config._rp_enabled is False
135135
mocked_log.debug.assert_has_calls(
136136
[
137-
mock.call(
138-
MANDATORY_PARAMETER_MISSED_PATTERN.format(
139-
mocked_config.option.rp_project,
140-
None,
141-
mocked_config.option.rp_api_key,
142-
)
143-
),
137+
mock.call(MANDATORY_PARAMETER_MISSED_PATTERN.format(mocked_config.option.rp_project, None)),
144138
mock.call("Disabling reporting to RP."),
145139
]
146140
)
@@ -164,13 +158,7 @@ def test_pytest_configure_misssing_rp_project(mocked_log, mocked_config):
164158
assert mocked_config._rp_enabled is False
165159
mocked_log.debug.assert_has_calls(
166160
[
167-
mock.call(
168-
MANDATORY_PARAMETER_MISSED_PATTERN.format(
169-
None,
170-
mocked_config.option.rp_endpoint,
171-
mocked_config.option.rp_api_key,
172-
)
173-
),
161+
mock.call(MANDATORY_PARAMETER_MISSED_PATTERN.format(None, mocked_config.option.rp_endpoint)),
174162
mock.call("Disabling reporting to RP."),
175163
]
176164
)
@@ -196,9 +184,7 @@ def test_pytest_configure_misssing_rp_uuid(mocked_log, mocked_config):
196184
[
197185
mock.call(
198186
MANDATORY_PARAMETER_MISSED_PATTERN.format(
199-
mocked_config.option.rp_project,
200-
mocked_config.option.rp_endpoint,
201-
None,
187+
mocked_config.option.rp_project, mocked_config.option.rp_endpoint
202188
)
203189
),
204190
mock.call("Disabling reporting to RP."),

0 commit comments

Comments
 (0)