Use os.path.sep

Author: drcrazy

patches/0001-fix-detect-pytest-bdd-scenario-module-path-on-Window.patch

@@ -93,14 +93,14 @@
 BACKGROUND_STEP_NAME = "Background"
 
 
-def _is_pytest_bdd_scenario_location(location_path: str) -> bool:
+def _is_pytest_bdd_scenario(location_path: str) -> bool:
     """
     Return True if the pytest collection path points at pytest-bdd's scenario module.
 
     ``Item.location[0]`` uses OS-native separators (backslashes on Windows), so a
     plain suffix check with ``/`` is not portable. See #418.
     """
-    return location_path.replace("\\", "/").endswith("/pytest_bdd/scenario.py")
+    return location_path.replace(os.path.sep, "/").endswith("/pytest_bdd/scenario.py")
 
 
 def trim_docstring(docstring: str) -> str:
@@ -917,7 +917,7 @@ def start_pytest_item(self, test_item: Optional[Item] = None):
         if not self.__started():
             self.start()
 
-        if PYTEST_BDD and _is_pytest_bdd_scenario_location(test_item.location[0]):
+        if PYTEST_BDD and _is_pytest_bdd_scenario(test_item.location[0]):
             self._bdd_item_by_name[test_item.name] = test_item
             return
 
@@ -938,7 +938,7 @@ def process_results(self, test_item: Item, report):
         if report.longrepr:
             self.post_log(test_item, report.longreprtext, log_level="ERROR")
 
-        if PYTEST_BDD and _is_pytest_bdd_scenario_location(test_item.location[0]):
+        if PYTEST_BDD and _is_pytest_bdd_scenario(test_item.location[0]):
             return
 
         leaf = self._tree_path[test_item][-1]
@@ -1021,7 +1021,7 @@ def finish_pytest_item(self, test_item: Optional[Item] = None) -> None:
         leaf = self._tree_path[test_item][-1]
         self._process_metadata_item_finish(leaf)
 
-        if PYTEST_BDD and _is_pytest_bdd_scenario_location(test_item.location[0]):
+        if PYTEST_BDD and _is_pytest_bdd_scenario(test_item.location[0]):
             del self._bdd_item_by_name[test_item.name]
             return
 

pytest_reportportal/service.py

@@ -15,24 +15,24 @@
 
 from delayed_assert import assert_expectations, expect
 
-from pytest_reportportal.service import _is_pytest_bdd_scenario_location
+from pytest_reportportal.service import _is_pytest_bdd_scenario
 
 
-def test_is_pytest_bdd_scenario_location_posix_path():
+def test_is_pytest_bdd_scenario_posix_path():
     """pytest-bdd scenario items use forward slashes in location on POSIX."""
     path = "/usr/lib/python3.12/site-packages/pytest_bdd/scenario.py"
-    assert _is_pytest_bdd_scenario_location(path) is True
+    assert _is_pytest_bdd_scenario(path) is True
 
 
-def test_is_pytest_bdd_scenario_location_windows_path():
+def test_is_pytest_bdd_scenario_windows_path():
     """pytest-bdd scenario items use backslashes in location on Windows (#418)."""
     path = r"C:\Python312\Lib\site-packages\pytest_bdd\scenario.py"
-    assert _is_pytest_bdd_scenario_location(path) is True
+    assert _is_pytest_bdd_scenario(path) is True
 
 
-def test_is_pytest_bdd_scenario_location_regular_test_module():
+def test_is_pytest_bdd_scenario_regular_test_module():
     """Regular tests must not be treated as pytest-bdd scenario glue."""
-    assert _is_pytest_bdd_scenario_location("/project/tests/test_foo.py") is False
+    assert _is_pytest_bdd_scenario("/project/tests/test_foo.py") is False
 
 
 def test_get_item_parameters(mocked_item, rp_service):