Commit 59c95b7
fix: show embedder dialog in the correct interactive branch
The embedder selection dialog was inserted in dead code (the
'not is_interactive' branch, which is never reached when stdin is a TTY).
The interactive provider select happens inside the 'if is_interactive:'
block (lines 316/326), so embedder_name must be set there too — before
_resolve_embedder() is called on line 349. Moving the dialog to both
provider-select call-sites (full and advanced mode) ensures:
- embedder_name is set before _resolve_embedder() sees it
- _resolve_embedder() short-circuits on a non-None flag and ignores env vars
- 'Embedder: gemini' no longer appears when GEMINI_API_KEY happens to be set
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 2572284 commit 59c95b7
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
317 | 320 | | |
318 | 321 | | |
319 | 322 | | |
| |||
324 | 327 | | |
325 | 328 | | |
326 | 329 | | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
327 | 333 | | |
328 | 334 | | |
329 | 335 | | |
| |||
377 | 383 | | |
378 | 384 | | |
379 | 385 | | |
380 | | - | |
381 | 386 | | |
382 | | - | |
383 | 387 | | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | 388 | | |
388 | 389 | | |
389 | 390 | | |
| |||
0 commit comments