fix: handle Anthropic thinking blocks#787
Open
tomasvn20 wants to merge 1 commit into
Open
Conversation
|
✅ Health: 7.6 (unchanged) 📋 At a glance Files & modules (2)
🩹 Review priority (files here with the most recent bug-fix history — defects cluster, so review these first)
🔎 More signals (2)🔥 Hotspots touched (2)
🔗 Hidden coupling (2 files)
📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-11 18:53 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnthropicProviderto scanresponse.contentfor the first block carrying text instead of assuming that the first content block is always aTextBlock.ThinkingBlockbefore the final text response.[ThinkingBlock, TextBlock]response.Related Issues
Fixes #750
Related to #740
Implementation Details
Anthropic responses can contain different content block types. When extended thinking is enabled, or when an Anthropic-compatible endpoint returns reasoning content, a
ThinkingBlockmay appear before the finalTextBlock.Previously, the provider accessed the first content block directly:
This caused an
AttributeErrorwhen the first block did not expose atextattribute.The provider now iterates through
response.contentand selects the first block that carries text:This preserves the existing behavior for standard Anthropic responses while supporting responses where thinking or reasoning blocks appear before the text.
Test Plan
[ThinkingBlock, TextBlock]content.13 passed).git diff --checkpasses.The full
make test-fastrun completed with 7,069 passing tests and 11 failures in unrelated CLI, update, and code-rationale tests. Representative failures also reproduce when executed independently and do not exercise the Anthropic provider changes.Checklist