fix(graph): execution-flow picker on the module overview; hierarchical layout guardrails#805
Merged
Merged
Conversation
…r works there The shell already supports picking a flow from the module overview — enterFullViewFromModule switches to the file-level graph and highlights the trace. But the wrapper only fetched flows for file-level scopes, so on the module overview the panel had no data and the toolbar button silently did nothing. Widen the fetch gate to include the module view; add a shell test covering the picker-then-jump path.
Past 500 nodes ELK never runs, but the toggle still activated: the force layout stopped and the button sat active doing nothing. Guard the mode switch itself — keep force running, surface the existing skip notice synchronously — instead of relying on the canvas hook to fire it after the mode has already changed.
…solated Modules with no dependency edges each became their own ELK component, packed side by side into one huge band that drowned out the layering. Lay out only the connected subgraph and shelve isolated modules in a grid below it.
|
✅ Health: 7.6 (unchanged) 📋 At a glance
🩹 Review priority (files here with the most recent bug-fix history — defects cluster, so review these first)
🔎 More signals (2)🔥 Hotspots touched (5)
2 more
🔗 Hidden coupling (2 files)
📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-07-12 10:33 UTC |
…graph lands; quiet sigma in jsdom
RaghavChamadiya
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three graph fixes:
Execution flows work from the module overview. The shell already jumps to the file-level graph and highlights the trace when a flow is picked (enterFullViewFromModule), but the web wrapper only fetched flows for file-level scopes — on the module overview the panel had no data and the toolbar button silently did nothing. The fetch gate now includes the module view. New shell test covers the picker-then-jump path.
Hierarchical layout refuses above the ELK cap at the click. Past 500 nodes ELK never runs, but the toggle still activated: the force layout stopped and the button sat active doing nothing. The mode switch is now guarded — force keeps running and the existing skip notice shows synchronously. Test renders a 501-node graph and asserts the refusal.
Hierarchical layers stay readable when most modules are isolated. Modules without dependency edges each became their own ELK component, packed side by side into one wide band that drowned out the layering. The connected subgraph gets the layered layout; isolated modules are shelved in a grid below it.