-
Notifications
You must be signed in to change notification settings - Fork 14
fixed bad urls and implemented mascot #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ const { data: posts } = await useAsyncData('blog-posts', () => | |
| <NuxtLink to="/catalog" class="transition hover:text-white">Features</NuxtLink> | ||
| <NuxtLink to="/blog" class="text-white transition">Blog</NuxtLink> | ||
| <a | ||
| href="https://github.com/joachimhorsworthy/reqcore" | ||
| href="https://github.com/reqcore-inc/reqcore" | ||
| target="_blank" | ||
| class="transition hover:text-white" | ||
|
Comment on lines
44
to
47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Harden both external GitHub links with Line 46 and Line 144 open new tabs without 🔒 Proposed fix <a
href="https://github.com/reqcore-inc/reqcore"
target="_blank"
+ rel="noopener noreferrer"
class="transition hover:text-white"
>
<Github class="size-4" />
</a>
@@
<a
href="https://github.com/reqcore-inc/reqcore"
target="_blank"
+ rel="noopener noreferrer"
class="transition hover:text-white/60"
>
GitHub
</a>Also applies to: 142-145 🤖 Prompt for AI Agents |
||
| > | ||
|
|
@@ -140,7 +140,7 @@ const { data: posts } = await useAsyncData('blog-posts', () => | |
| <NuxtLink to="/" class="transition hover:text-white/60">Home</NuxtLink> | ||
| <NuxtLink to="/roadmap" class="transition hover:text-white/60">Roadmap</NuxtLink> | ||
| <a | ||
| href="https://github.com/joachimhorsworthy/reqcore" | ||
| href="https://github.com/reqcore-inc/reqcore" | ||
| target="_blank" | ||
| class="transition hover:text-white/60" | ||
| > | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -243,7 +243,7 @@ const stats = computed(() => { | |||||||||||||||||||||||||||
| Blog | ||||||||||||||||||||||||||||
| </NuxtLink> | ||||||||||||||||||||||||||||
| <a | ||||||||||||||||||||||||||||
| href="https://github.com/reqcore/reqcore" | ||||||||||||||||||||||||||||
| href="https://github.com/reqcore-inc/reqcore" | ||||||||||||||||||||||||||||
| target="_blank" | ||||||||||||||||||||||||||||
| rel="noopener noreferrer" | ||||||||||||||||||||||||||||
| class="hidden items-center gap-1.5 rounded-md px-3 py-1.5 text-[13px] font-medium text-surface-400 transition hover:text-white sm:flex" | ||||||||||||||||||||||||||||
|
|
@@ -538,7 +538,7 @@ const stats = computed(() => { | |||||||||||||||||||||||||||
| <div class="flex items-center gap-2"> | ||||||||||||||||||||||||||||
| <span>Open source on</span> | ||||||||||||||||||||||||||||
| <a | ||||||||||||||||||||||||||||
| href="https://github.com/reqcore/reqcore" | ||||||||||||||||||||||||||||
| href="https://github.com/reqcore-inc/reqcore" | ||||||||||||||||||||||||||||
| target="_blank" | ||||||||||||||||||||||||||||
| class="inline-flex items-center gap-1 text-white/50 hover:text-white transition" | ||||||||||||||||||||||||||||
|
Comment on lines
540
to
543
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add Line 542 uses 🔒 Proposed fix <a
href="https://github.com/reqcore-inc/reqcore"
target="_blank"
+ rel="noopener noreferrer"
class="inline-flex items-center gap-1 text-white/50 hover:text-white transition"
>
GitHub <ArrowUpRight class="size-3" />
</a>📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
rel="noopener noreferrer"to new-tab external links.Line 74 and Line 174 open external URLs in a new tab without
rel, which leaves a reverse-tabnabbing vector.🔒 Proposed fix
<a href="https://github.com/reqcore-inc/reqcore" target="_blank" + rel="noopener noreferrer" class="transition hover:text-white" > <Github class="size-4" /> </a> @@ <a href="https://github.com/reqcore-inc/reqcore" target="_blank" + rel="noopener noreferrer" class="transition hover:text-white/60" > GitHub </a>Also applies to: 172-175
🤖 Prompt for AI Agents