Try fixing connector for AspNetAndMSDI (#156)

* enable running the tests for VsExtConnectorTestSamples.AspNetAndMSDI

* the one-line fix, but...

* resolve dependencies from NuGet in a smarter way (not just from the first folder we find)

* apply the fix selectively

* add comment about _shortFrameworkName

* update CHANGELOG

* Add VsExtConnectorTestSamples.AspNetAndMSDI sample

# Conflicts:
#	Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.slnx

Author: gasparnagy

CHANGELOG.md

@@ -8,6 +8,8 @@
 
 ## Bug fixes:
 
+* Fix: Binding discovery for .NET 10 projects that depend on an ASP.NET project and use the MSDI plugin (#156)
+
 *Contributors of this release (in alphabetical order):* @304NotModified, @clrudolphi, @gasparnagy
 
 # v2025.3.395 - 2025-12-17

Connectors/Reqnroll.VisualStudio.ReqnrollConnector.Generic/AssemblyLoading/NugetCacheAssemblyResolver.cs

@@ -5,6 +5,14 @@ namespace ReqnrollConnector.AssemblyLoading;
 
 public class NugetCacheAssemblyResolver : ICompilationAssemblyResolver
 {
+    private const string NetStandard20 = "netstandard2.0";
+    private readonly string _targetFramework;
+
+    public NugetCacheAssemblyResolver(string targetFramework)
+    {
+        _targetFramework = targetFramework;
+    }
+
     public bool TryResolveAssemblyPaths(CompilationLibrary library, List<string>? assemblies)
     {
         if (library.Path == null || assemblies == null)
@@ -15,14 +23,31 @@ public bool TryResolveAssemblyPaths(CompilationLibrary library, List<string>? as
         if (!Directory.Exists(directory))
             return false;
 
-        var libs = Directory.GetDirectories(directory);
-        foreach (var lib in libs)
+        string assemblyFileName = library.Name + ".dll";
+
+        // If the target framework folder exists, use it, even if it doesn't contain the assembly.
+        // An empty folder indicates that the package is included to the target framework by default.
+        if (Directory.Exists(Path.Combine(directory, _targetFramework)))
+        {
+            assemblies.Add(Path.Combine(directory, _targetFramework, assemblyFileName));
+            return true;
+        }
+
+        // Fallback to netstandard2.0, similarly
+        if (Directory.Exists(Path.Combine(directory, NetStandard20)))
+        {
+            assemblies.Add(Path.Combine(directory, NetStandard20, assemblyFileName));
+            return true;
+        }
+
+        // Finally, check if the assembly exists directly under lib (old .NET Framework style packages)
+        if (Directory.Exists(Path.Combine(directory, assemblyFileName)))
         {
-            var assemblyFilePath = Path.Combine(lib, library.Name + ".dll");
-            assemblies.Add(assemblyFilePath);
+            assemblies.Add(Path.Combine(directory, assemblyFileName));
+            return true;
         }
 
-        return libs.Any();
+        return false;
     }
 
     private string NugetCacheExpandedPath()

Connectors/Reqnroll.VisualStudio.ReqnrollConnector.Generic/AssemblyLoading/TestAssemblyLoadContext.cs

@@ -41,7 +41,7 @@ public TestAssemblyLoadContext(
             new ReferenceAssemblyPathResolver(),
             new PackageCompilationAssemblyResolver(),
             new AspNetCoreAssemblyResolver(),
-            new NugetCacheAssemblyResolver()
+            new NugetCacheAssemblyResolver(_shortFrameworkName)
         }, _log);
     }
 
@@ -187,6 +187,12 @@ private IEnumerable<string> SelectAssets(IReadOnlyList<RuntimeAssetGroup> runtim
 
     private CompilationLibrary GetRequestedLibrary(AssemblyName assemblyName)
     {
+        // Using a x.y.z path allows finding the library in NuGet cache folders.
+        // This causes problems with System.* assemblies (e.g. System.Text.Encodings.Web in .NET 8.0), so we use the full version string for those.
+        string path = !assemblyName.Name!.StartsWith("System.", StringComparison.InvariantCultureIgnoreCase) ?
+                Path.Combine(assemblyName.Name!, $"{assemblyName.Version!.Major}.{assemblyName.Version!.Minor}.{assemblyName.Version!.MajorRevision}".ToString()) :
+                Path.Combine(assemblyName.Name!, $"{assemblyName.Version}".ToString());
+
         // This reference might help finding dependencies that are otherwise not listed in the
         // deps.json file of the test assembly. E.g. Microsoft.AspNetCore.Hosting.Abstractions in the ReqOverflow.Specs.API project of the https://github.com/reqnroll/Sample-ReqOverflow sample
         return new CompilationLibrary(
@@ -197,7 +203,7 @@ private CompilationLibrary GetRequestedLibrary(AssemblyName assemblyName)
             new[] {assemblyName.Name + ".dll"},
             Array.Empty<Dependency>(),
             true,
-            Path.Combine(assemblyName.Name!, $"{assemblyName.Version}".ToString()),
+            path,
             string.Empty);
     }
 

Tests/Connector/Reqnroll.VisualStudio.ReqnrollConnector.Tests/ExternalSampleTests.cs

@@ -18,7 +18,7 @@ public void ReqOverflow(string testCase, string projectFile, string repositoryDi
     }
 
     private const string IgnoredExploratoryTestProjects =
-        "SpecFlowCompatibilityProject.Net472;CleanReqnrollProject.Net481.x86;VsExtConnectorTestSamples";
+        "SpecFlowCompatibilityProject.Net472;CleanReqnrollProject.Net481.x86;VsExtConnectorTestSamples.NetFwSystemDataDep";
 
     [Theory]
     [MemberData(nameof(GetProjectsForRepository), "https://github.com/reqnroll/Reqnroll.ExploratoryTestProjects", $"BigReqnrollProject;SpecFlowProject;OldProjectFileFormat.Empty;ReqnrollFormatters.CustomizedHtml;CustomPlugins.TagDecoratorGeneratorPlugin;{IgnoredExploratoryTestProjects}")]

Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.AspNetAndMSDI.App/Controllers/HomeController.cs

@@ -0,0 +1,24 @@
+using System.Diagnostics;
+using Microsoft.AspNetCore.Mvc;
+using VsExtConnectorTestSamples.AspNetAndMSDI.App.Models;
+
+namespace VsExtConnectorTestSamples.AspNetAndMSDI.App.Controllers;
+
+public class HomeController : Controller
+{
+    public IActionResult Index()
+    {
+        return View();
+    }
+
+    public IActionResult Privacy()
+    {
+        return View();
+    }
+
+    [ResponseCache(Duration = 0, Location = ResponseCacheLocation.None, NoStore = true)]
+    public IActionResult Error()
+    {
+        return View(new ErrorViewModel { RequestId = Activity.Current?.Id ?? HttpContext.TraceIdentifier });
+    }
+}

Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.AspNetAndMSDI.App/Interfaces/IDateTimeService.cs

@@ -0,0 +1,6 @@
+namespace VsExtConnectorTestSamples.AspNetAndMSDI.App.Interfaces;
+
+public interface IDateTimeService
+{
+    DateTime GetDateTime();
+}

Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.AspNetAndMSDI.App/Models/ErrorViewModel.cs

@@ -0,0 +1,8 @@
+namespace VsExtConnectorTestSamples.AspNetAndMSDI.App.Models;
+
+public class ErrorViewModel
+{
+    public string? RequestId { get; set; }
+
+    public bool ShowRequestId => !string.IsNullOrEmpty(RequestId);
+}

Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.AspNetAndMSDI.App/Program.cs

@@ -0,0 +1,39 @@
+using VsExtConnectorTestSamples.AspNetAndMSDI.App.Interfaces;
+using VsExtConnectorTestSamples.AspNetAndMSDI.App.Services;
+
+namespace VsExtConnectorTestSamples.AspNetAndMSDI.App;
+
+public class Program
+{
+    public static void Main(string[] args)
+    {
+        var builder = WebApplication.CreateBuilder(args);
+
+        // Add services to the container.
+        builder.Services.AddControllersWithViews();
+        builder.Services.AddSingleton<IDateTimeService, DateTimeService>();
+
+        var app = builder.Build();
+
+        // Configure the HTTP request pipeline.
+        if (!app.Environment.IsDevelopment())
+        {
+            app.UseExceptionHandler("/Home/Error");
+            // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
+            app.UseHsts();
+        }
+
+        app.UseHttpsRedirection();
+        app.UseRouting();
+
+        app.UseAuthorization();
+
+        app.MapStaticAssets();
+        app.MapControllerRoute(
+               name: "default",
+               pattern: "{controller=Home}/{action=Index}/{id?}")
+           .WithStaticAssets();
+
+        app.Run();
+    }
+}

Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.AspNetAndMSDI.App/Services/DateTimeService.cs

@@ -0,0 +1,11 @@
+using VsExtConnectorTestSamples.AspNetAndMSDI.App.Interfaces;
+
+namespace VsExtConnectorTestSamples.AspNetAndMSDI.App.Services;
+
+public class DateTimeService : IDateTimeService
+{
+    public DateTime GetDateTime()
+    {
+        return DateTime.Now;
+    }
+}

Tests/VsExtConnectorTestSamples/VsExtConnectorTestSamples.AspNetAndMSDI.App/Views/Home/Index.cshtml

@@ -0,0 +1,8 @@
+@{
+    ViewData["Title"] = "Home Page";
+}
+
+<div class="text-center">
+    <h1 class="display-4">Welcome</h1>
+    <p>Learn about <a href="https://learn.microsoft.com/aspnet/core">building Web apps with ASP.NET Core</a>.</p>
+</div>