Rn r1078 fix invalid handling of long generated file path lengths#1079
Open
clrudolphi wants to merge 3 commits intomainfrom
Open
Rn r1078 fix invalid handling of long generated file path lengths#1079clrudolphi wants to merge 3 commits intomainfrom
clrudolphi wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Modified
GeneratedFileWriterto include a\\?\or '\?\UNC` prefix when running under Windows.⚡️ What's your motivation?
To properly support file paths longer than 260 characters as reported in #1078
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
TESTING:
I have been able to reproduce the problem locally and convince myself that this PR addresses the issue.
However, this PR is lacking tests as I'm unsure how to proceed with testing. Our CI runs under both OSes and even then usually only under net8 or net10. It is my impression that this problem is going to be most prevalent when running the MSBuild task under .NET Framework on Windows only.
Would you prefer to see a completely new test added to CI so that we can force those conditions?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.