Skip to content

Rn r1078 fix invalid handling of long generated file path lengths#1079

Open
clrudolphi wants to merge 3 commits intomainfrom
RnR1078_FixInvalidHandlingOfLongGeneratedFilePathLengths
Open

Rn r1078 fix invalid handling of long generated file path lengths#1079
clrudolphi wants to merge 3 commits intomainfrom
RnR1078_FixInvalidHandlingOfLongGeneratedFilePathLengths

Conversation

@clrudolphi
Copy link
Copy Markdown
Contributor

@clrudolphi clrudolphi commented Apr 28, 2026

🤔 What's changed?

Modified GeneratedFileWriter to include a \\?\ or '\?\UNC` prefix when running under Windows.

⚡️ What's your motivation?

To properly support file paths longer than 260 characters as reported in #1078

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

TESTING:
I have been able to reproduce the problem locally and convince myself that this PR addresses the issue.
However, this PR is lacking tests as I'm unsure how to proceed with testing. Our CI runs under both OSes and even then usually only under net8 or net10. It is my impression that this problem is going to be most prevalent when running the MSBuild task under .NET Framework on Windows only.
Would you prefer to see a completely new test added to CI so that we can force those conditions?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@clrudolphi clrudolphi requested a review from gasparnagy April 28, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant