Update Client after refresh regardless of if token_updater is specified#487
Open
hiporox wants to merge 2 commits intorequests:masterfrom
Open
Update Client after refresh regardless of if token_updater is specified#487hiporox wants to merge 2 commits intorequests:masterfrom
token_updater is specified#487hiporox wants to merge 2 commits intorequests:masterfrom
Conversation
hiporox
changed the title
token_updater is specified
|
UP. Do we have any updates about this PR ? Can someone merge it ? |
Contributor
|
Pushing a small change to kick off the PR build checks and tests |
Contributor
|
Looks like all the checks/unit tests have passed, is it possible to get/produce some evidence of integration or manual smoke/regression tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that if a
token_updateris not specified, the client will not get updated. Instead of providing a defaulttoken_updater, we can instead move this client update call to happen after refresh regardlessFixes #411