chore: trying to find out the proper way to use Adapters

Author: tfoldi

rerun_bridge/src/rerun_bridge/collection_adapters.hpp

@@ -25,14 +25,3 @@ struct rerun::CollectionAdapter<TElement, cv::Mat> {
 inline rerun::WidthHeight width_height(const cv::Mat& img) {
     return rerun::WidthHeight(static_cast<size_t>(img.cols), static_cast<size_t>(img.rows));
 };
-
-template <typename T>
-rerun::Collection<T> img_data_as_collection(const cv::Mat& img) {
-    const T* img_data = reinterpret_cast<const T*>(img.data);
-
-    size_t img_size = img.total() * img.channels();
-
-    std::vector<T> img_vec(img_data, img_data + img_size);
-
-    return rerun::Collection<T>::take_ownership(std::move(img_vec));
-}

rerun_bridge/src/rerun_bridge/rerun_ros_interface.cpp

@@ -116,7 +116,7 @@ void log_image(
         cv::Mat img = cv_bridge::toCvCopy(msg)->image;
         rec.log(
             entity_path,
-            rerun::DepthImage(img_data_as_collection<uint16_t>(img), width_height(img)).with_meter(1000)
+            rerun::DepthImage(rerun::Collection<uint16_t>(img), width_height(img)).with_meter(1000)
         );
     } else if (msg->encoding == "32FC1") {
         cv::Mat img = cv_bridge::toCvCopy(msg)->image;
@@ -128,13 +128,13 @@ void log_image(
         }
         rec.log(
             entity_path,
-            rerun::DepthImage(img_data_as_collection<float>(img), width_height(img)).with_meter(1.0)
+            rerun::DepthImage(rerun::Collection<float>(img), width_height(img)).with_meter(1.0)
         );
     } else {
         cv::Mat img = cv_bridge::toCvCopy(msg, "rgb8")->image;
         rec.log(
             entity_path,
-            rerun::Image::from_rgb24(img_data_as_collection<uint8_t>(img), width_height(img))
+            rerun::Image::from_rgb24(rerun::Collection<uint8_t>(img), width_height(img))
         );
     }
 }