Include SharedWorker in WebWorkerAPI#129
Merged
nojaf merged 12 commits intorescript-lang:mainfrom Jul 28, 2025
Merged
Conversation
…al-rescript-webapi into feature/shared-worker
Feature/shared worker
revert accidentally committed files.
nojaf
requested changes
Jul 27, 2025
Member
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
Hello, thank you for this solid PR.
Apologies again for the underscore naming thing.
Could you update those, then we are good to go I think.
Contributor
Author
|
(I kinda like it without the underscores, anyway tbh. |
nojaf
approved these changes
Jul 28, 2025
Member
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
Thank you! After CI ran on my main, there should be a new package published on npm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #112.
This adds bindings for the SharedWorker interface and SharedWorkerGlobalScope interface.
I also took the liberty of adding "*~" to the bottom of your .gitignore. Emacs automatically adds backup files ending in a tilde, which gets annoying if it's not in your .gitignore. Feel free to reject that, of course, but I figure other emacs users who are contributors to the project would enjoy having that there.
Let me know if you need style changes or anything. Thank you for maintaining this!