Skip to content

Array docstrings#78

Merged
zth merged 11 commits into
mainfrom
array-docstrings
Mar 9, 2023
Merged

Array docstrings#78
zth merged 11 commits into
mainfrom
array-docstrings

Conversation

@zth

@zth zth commented Feb 28, 2023

Copy link
Copy Markdown
Member

I've done most of the docstrings, enough to get a new release out at least.

@zth zth mentioned this pull request Feb 28, 2023
49 tasks
@zth zth force-pushed the array-docstrings branch from eeba736 to 7bbdff0 Compare March 6, 2023 17:37
@glennsl

glennsl commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Will you remove the unsafe from and fromWithMap functions as well?

@zth

zth commented Mar 6, 2023

Copy link
Copy Markdown
Member Author

Will you remove the unsafe from and fromWithMap functions as well?

I was going to rename them fromUnsafe and fromWithMapperUnsafe as a first step.

@zth

zth commented Mar 8, 2023

Copy link
Copy Markdown
Member Author

@glennsl I ended up removing them instead.

@zth zth force-pushed the array-docstrings branch from 5a61765 to ebd09d6 Compare March 8, 2023 10:17
@zth zth marked this pull request as ready for review March 8, 2023 10:17
@zth zth requested a review from cknitt March 8, 2023 10:18
@zth

zth commented Mar 8, 2023

Copy link
Copy Markdown
Member Author

Ready for review. @glennsl would you have a look at this too?

@glennsl glennsl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, and most of them are repeated throughout, but I've avoided adding repetitive comments. So if you agree with a remark, it's a good idea to look over the rest for the same issue.

Comment thread src/Core__Array.res
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Array.resi Outdated
Comment thread src/Core__Iterator.resi Outdated
@zth zth added this to the 0.2.0 milestone Mar 9, 2023
@zth

zth commented Mar 9, 2023

Copy link
Copy Markdown
Member Author

Thanks for the good feedback @glennsl , I think I covered all of it. I'm going to merge this so we can get closer to a new release. Can rework any remaining issues here later on.

@zth zth merged commit e584301 into main Mar 9, 2023
@zth zth deleted the array-docstrings branch March 9, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants