Array docstrings#78
Merged
Merged
Conversation
Contributor
|
Will you remove the unsafe |
Member
Author
I was going to rename them |
Member
Author
|
@glennsl I ended up removing them instead. |
Member
Author
|
Ready for review. @glennsl would you have a look at this too? |
glennsl
reviewed
Mar 8, 2023
Co-authored-by: Glenn Slotte <glenn@slotte.net>
Member
Author
|
Thanks for the good feedback @glennsl , I think I covered all of it. I'm going to merge this so we can get closer to a new release. Can rework any remaining issues here later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done most of the docstrings, enough to get a new release out at least.