Skip to content

Commit 80b836d

Browse files
committed
done with mobile overlay
1 parent 482b405 commit 80b836d

3 files changed

Lines changed: 28 additions & 14 deletions

File tree

__tests__/NavbarPrimary_.test.res

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,24 +58,32 @@ test("phone has some things hidden and a mobile nav that can be toggled", async
5858
</BrowserRouter>,
5959
)
6060

61-
// await element(screen->getByText("Docs"))->toBeVisible
62-
// await element(screen->getByText("Playground"))->notToBeVisible
63-
// await element(screen->getByText("Blog"))->notToBeVisible
64-
// await element(screen->getByText("Community"))->notToBeVisible
61+
let leftContent = await screen->getByTestId("navbar-primary-left-content")
6562

66-
await element(screen->getByTestId("mobile-nav"))->notToBeVisible
63+
await element(leftContent->getByText("Docs"))->toBeVisible
64+
await element(leftContent->getByText("Playground"))->notToBeVisible
65+
await element(leftContent->getByText("Blog"))->notToBeVisible
66+
await element(leftContent->getByText("Community"))->notToBeVisible
67+
68+
let rightContent = await screen->getByTestId("navbar-primary-right-content")
6769

68-
// await element(screen->getByLabelText("Github"))->notToBeVisible
69-
// await element(screen->getByLabelText("X (formerly Twitter)"))->notToBeVisible
70-
// await element(screen->getByLabelText("Bluesky"))->notToBeVisible
71-
// await element(screen->getByLabelText("Forum"))->notToBeVisible
70+
await element(rightContent->getByLabelText("Github"))->notToBeVisible
71+
await element(rightContent->getByLabelText("X (formerly Twitter)"))->notToBeVisible
72+
await element(rightContent->getByLabelText("Bluesky"))->notToBeVisible
73+
await element(rightContent->getByLabelText("Forum"))->notToBeVisible
74+
75+
await element(screen->getByTestId("mobile-nav"))->notToBeVisible
7276

7377
let button = await screen->getByTestId("toggle-mobile-overlay")
7478

7579
await element(button)->toBeVisible
7680

7781
await button->click
7882

83+
let mobileNav = await screen->getByTestId("mobile-nav")
84+
85+
await element(mobileNav)->toBeVisible
86+
7987
// await element(screen->getByLabelText("Github"))->toBeVisible
8088
// await element(screen->getByLabelText("X (formerly Twitter)"))->toBeVisible
8189
// await element(screen->getByLabelText("Bluesky"))->toBeVisible

src/components/NavbarMobileOverlay.res

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,7 @@ module MobileNav = {
66
let make = (~route: Path.t) => {
77
let base = "font-normal mx-4 py-5 text-gray-40 border-b border-gray-80"
88
let extLink = "block hover:cursor-pointer hover:text-white text-gray-60"
9-
<ul
10-
dataTestId="mobile-nav"
11-
className="border-gray-80 border-tn top-16 flex-col fixed h-full w-full z-50 sm:w-9/12 bg-gray-100 sm:h-auto sm:flex sm:relative sm:flex-row sm:justify-between"
12-
>
9+
<ul dataTestId="mobile-nav">
1310
<li className=base>
1411
<Link
1512
prefetch={#intent}
@@ -94,7 +91,11 @@ let make = () => {
9491
Some(closeMobileOverlay)
9592
}, [])
9693

97-
<dialog id="mobile-overlay" onClick={handleBackdropClick}>
94+
<dialog
95+
id="mobile-overlay"
96+
onClick={handleBackdropClick}
97+
className="top-16 flex-col h-full w-full z-50 bg-gray-100 overflow-scroll pb-8"
98+
>
9899
<MobileNav route />
99100
</dialog>
100101
}

styles/main.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,11 @@ body:has(dialog[open]) {
395395
overflow: hidden;
396396
}
397397

398+
#mobile-overlay {
399+
max-width: 100%;
400+
margin: 0;
401+
}
402+
398403
body {
399404
scrollbar-gutter: stable;
400405
}

0 commit comments

Comments
 (0)