fix: handle crawler search hits without url_without_anchor

Treat DocSearch crawler hit url_without_anchor as optional and derive it from the hit URL when absent so transformItems does not throw before rendering results.

Author: jderochervlk

__tests__/Search_.test.res

@@ -8,7 +8,7 @@ let makeHit = (~type_: DocSearch.contentType, ~url: string): DocSearch.docSearch
   objectID: "test",
   content: Nullable.null,
   url,
-  url_without_anchor: url,
+  url_without_anchor: Nullable.make(url),
   type_,
   anchor: Nullable.null,
   hierarchy: {
@@ -262,11 +262,31 @@ test("normalizeHitUrls rewrites absolute site URLs to relative paths", async ()
   expect(result[0]->Option.map(hit => hit.url))->toEqual(
     Some("/docs/manual/typescript-integration#gentype"),
   )
-  expect(result[0]->Option.map(hit => hit.url_without_anchor))->toEqual(
+  expect(result[0]->Option.flatMap(hit => hit.url_without_anchor->Nullable.toOption))->toEqual(
     Some("/docs/manual/typescript-integration#gentype"),
   )
 })
 
+test("normalizeHitUrls tolerates crawler hits without url_without_anchor", async () => {
+  let hit: DocSearch.docSearchHit = Obj.magic(
+    Dict.fromArray([
+      ("objectID", "crawler-hit"),
+      ("content", "map(array, fn) returns a new array."),
+      ("url", "https://rescript-lang.org/docs/manual/api/stdlib/array/#value-map"),
+      ("type", "content"),
+    ]),
+  )
+
+  let result = Search.normalizeHitUrls([hit], ~siteUrl="https://rescript-lang.org/")
+
+  expect(result[0]->Option.map(hit => hit.url))->toEqual(
+    Some("/docs/manual/api/stdlib/array/#value-map"),
+  )
+  expect(result[0]->Option.flatMap(hit => hit.url_without_anchor->Nullable.toOption))->toEqual(
+    Some("/docs/manual/api/stdlib/array/"),
+  )
+})
+
 test("renders disabled search copy when Algolia config is missing", async () => {
   await viewport(1440, 500)
 

src/bindings/DocSearch.res

@@ -23,7 +23,7 @@ type docSearchHit = {
   objectID: string,
   content: Nullable.t<string>,
   url: string,
-  url_without_anchor: string,
+  url_without_anchor: Nullable.t<string>,
   @as("type") type_: contentType,
   anchor: Nullable.t<string>,
   hierarchy: hierarchy,

src/components/Search.res

@@ -22,7 +22,11 @@ let toRelativeSiteUrl = (url: string, ~siteUrl: string): string => {
 let normalizeHitUrls = (items: array<DocSearch.docSearchHit>, ~siteUrl: string) =>
   items->Array.map(hit => {
     let url = toRelativeSiteUrl(hit.url, ~siteUrl)
-    let url_without_anchor = toRelativeSiteUrl(hit.url_without_anchor, ~siteUrl)
+    let urlWithoutAnchor =
+      hit.url_without_anchor
+      ->Nullable.toOption
+      ->Option.getOr(hit.url->String.split("#")->Array.get(0)->Option.getOr(hit.url))
+    let url_without_anchor = toRelativeSiteUrl(urlWithoutAnchor, ~siteUrl)->Nullable.make
     {...hit, url, url_without_anchor}
   })