[codex] Split sidebar layout modules#1279
Open
jderochervlk wants to merge 6 commits intomasterfrom
Open
Conversation
Move the sidebar navigation, breadcrumbs, and page shell into separate ReScript modules and update routes/tests to use the new names.
jderochervlk
commented
Apr 28, 2026
Collaborator
Author
There was a problem hiding this comment.
This was updated because of the new logo.
jderochervlk
commented
Apr 28, 2026
jderochervlk
commented
Apr 28, 2026
jderochervlk
commented
Apr 28, 2026
…-layout # Conflicts: # __tests__/SidebarLayout_.test.res # __tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-breadcrumbs-chromium-linux.png # __tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-breadcrumbs-deep-chromium-linux.png # __tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-active-item-chromium-linux.png # __tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-chromium-linux.png # __tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-many-items-chromium-linux.png # __tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-with-toc-chromium-linux.png # apps/docs/__tests__/Breadcrumbs_.test.res # apps/docs/__tests__/SidebarLayout_.test.res # apps/docs/__tests__/SidebarNav_.test.res # apps/docs/__tests__/__screenshots__/Breadcrumbs_.test.jsx/sidebar-breadcrumbs-chromium-linux.png # apps/docs/__tests__/__screenshots__/Breadcrumbs_.test.jsx/sidebar-breadcrumbs-deep-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-breadcrumbs-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-breadcrumbs-deep-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-active-item-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-many-items-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarLayout_.test.jsx/sidebar-category-with-toc-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarNav_.test.jsx/sidebar-category-active-item-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarNav_.test.jsx/sidebar-category-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarNav_.test.jsx/sidebar-category-many-items-chromium-linux.png # apps/docs/__tests__/__screenshots__/SidebarNav_.test.jsx/sidebar-category-with-toc-chromium-linux.png # apps/docs/src/components/Breadcrumbs.res # apps/docs/src/components/Breadcrumbs.resi # apps/docs/src/components/SidebarNav.res # apps/docs/src/components/SidebarNav.resi # apps/docs/src/layouts/SidebarLayout.res # apps/docs/src/layouts/SidebarLayout.resi # apps/docs/src/layouts/SidebarPageLayout.res # apps/docs/src/layouts/SidebarPageLayout.resi
tsnobip
requested changes
Apr 28, 2026
Comment on lines
+4
to
+11
| type raw = Dict.t<{ | ||
| "title": string, | ||
| "category": Nullable.t<string>, | ||
| "headers": array<{ | ||
| "name": string, | ||
| "href": Path.t, | ||
| }>, | ||
| }> |
Member
There was a problem hiding this comment.
I can't see that being used anywhere
Carry current master into PR #1279 and preserve the DocSearch crawl markers on the renamed SidebarPageLayout shell.
Cloudflare deploymentDeployement ID: 4e334ba4-2fc6-4138-ad1d-7ba590ad93bf ⛅️ wrangler 4.85.0 ✨ Uploading _redirects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SidebarLayouthad grown into a mixed module that contained the page shell, reusable sidebar navigation, TOC rendering, and breadcrumbs. This splits those concerns into clearer module names while preserving the existing rendered behavior.Summary
SidebarPageLayout.src/components/SidebarNav.src/components/Breadcrumbs.Validation
yarn build:resyarn vitest --browser.headless --run __tests__/SidebarNav_.test.jsx __tests__/Breadcrumbs_.test.jsx __tests__/DocsLayout_.test.jsx __tests__/CommunityLayout_.test.jsx __tests__/ApiOverviewLayout_.test.jsxyarn vitest --browser.headless --run __tests__/LandingPage_.test.jsx -t "landing trusted by snapshots"git diff --check