feat: makes type checking more strict

Author: mabasic

.helix/config.toml

@@ -0,0 +1,2 @@
+[editor]
+auto-format = false

server/src/server.ts

@@ -1445,19 +1445,19 @@ async function onMessage(msg: p.Message) {
             // TODO: Support range for full, and add delta support
             full: true,
           },
-          inlayHintProvider: config.extensionConfiguration.inlayHints?.enable,
-          codeLensProvider: config.extensionConfiguration.codeLens
-            ? {
-                workDoneProgress: false,
-              }
-            : undefined,
-          signatureHelpProvider: config.extensionConfiguration.signatureHelp
-            ?.enabled
-            ? {
-                triggerCharacters: ["("],
-                retriggerCharacters: ["=", ","],
-              }
-            : undefined,
+          inlayHintProvider:
+            config.extensionConfiguration.inlayHints?.enable || false,
+          ...(config.extensionConfiguration.codeLens && {
+            codeLensProvider: {
+              workDoneProgress: false,
+            },
+          }),
+          ...(config.extensionConfiguration.signatureHelp?.enabled && {
+            signatureHelpProvider: {
+              triggerCharacters: ["("],
+              retriggerCharacters: ["=", ","],
+            },
+          }),
         },
       };
       let response: p.ResponseMessage = {

server/src/utils.ts

@@ -969,7 +969,9 @@ export let parseCompilerLogOutput = async (
       let diagnostic: p.Diagnostic = {
         severity: parsedDiagnostic.severity,
         tags: parsedDiagnostic.tag === undefined ? [] : [parsedDiagnostic.tag],
-        code: parsedDiagnostic.code,
+        ...(parsedDiagnostic.code && {
+          code: parsedDiagnostic.code,
+        }),
         range,
         source: "ReScript",
         message,

server/tsconfig.json

@@ -1,4 +1,5 @@
 {
+  "$schema": "https://json.schemastore.org/tsconfig",
   "compilerOptions": {
     "target": "es2019",
     "lib": ["ES2019"],
@@ -8,6 +9,8 @@
     "strict": true,
     "outDir": "out",
     "rootDir": "src",
+    "strictNullChecks": true,
+    "exactOptionalPropertyTypes": true,
     "esModuleInterop": true
   },
   "include": ["src"],