Skip to content

Commit a954b6f

Browse files
committed
Code review feedback
1 parent a99ee84 commit a954b6f

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

server/src/incrementalCompilation.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ function remapCodeActionsToSourceFile(
503503
const actions = Object.values(codeActions)[0] ?? [];
504504

505505
// Code actions will point to the locally saved incremental file, so we must remap
506-
// them so the editor understand it's supposed to apply them to the unsaved doc,
506+
// them so the editor understands it's supposed to apply them to the unsaved doc,
507507
// not the saved "dummy" incremental file.
508508
actions.forEach((ca) => {
509509
if (ca.codeAction.edit != null && ca.codeAction.edit.changes != null) {
@@ -713,7 +713,7 @@ async function compileContents(
713713
};
714714

715715
try {
716-
const { stdout, stderr } = await execFilePromise(
716+
const { stderr } = await execFilePromise(
717717
entry.project.bscBinaryLocation,
718718
callArgs,
719719
{ cwd, signal },
@@ -736,11 +736,6 @@ async function compileContents(
736736
return;
737737
}
738738

739-
getLogger().log("Resetting compilation status.");
740-
// Reset compilation status as this compilation finished
741-
entry.compilation = null;
742-
entry.abortCompilation = null;
743-
744739
const { result, codeActions } = await utils.parseCompilerLogOutput(
745740
`${stderr}\n#Done()`,
746741
);
@@ -756,6 +751,11 @@ async function compileContents(
756751
return;
757752
}
758753

754+
getLogger().log("Resetting compilation status.");
755+
// Reset compilation status as this compilation finished
756+
entry.compilation = null;
757+
entry.abortCompilation = null;
758+
759759
processAndPublishDiagnostics(
760760
entry,
761761
result,

0 commit comments

Comments
 (0)