get rid of some warning output

Author: zth

packages/@rescript/runtime/Js_array2.res

@@ -438,7 +438,7 @@ numbers == [1, 10, 2, 20, 3, 30]
 */
 @deprecated({
   reason: "Use `Array.toSorted` instead.",
-  migrate: Array.toSorted((a, b) =>
+  migrate: Array.toSorted((_a, _b) =>
     %todo_("This needs a comparator function. Use `String.compare` for strings, etc.")
   ),
 })

tests/tools_tests/src/expected/OptionalArgRename.res.expected

@@ -1,7 +1,11 @@
 module Target = {
-  let doStuff = (~newName: option<int>=?) => ()
+  let doStuff = (~newName: option<int>=?) => {
+    ignore(newName)
+  }
 }
 
+let _ = Target.doStuff
+
 external doStuff: (~oldName: option<int>=?) => unit = "doStuff"
 
 /* Intentionally no usage here; this test exercises migration config parsing and ensures optional label rename is preserved and doesn’t crash. */

tests/tools_tests/src/expected/StdlibMigration_Array.res.expected

@@ -133,10 +133,10 @@ let pushMany1 = [1, 2, 3]->Array.pushMany([4, 5])
 let pushMany2 = Array.pushMany([1, 2, 3], [4, 5])
 
 let sortInPlace1 =
-  ["c", "a", "b"]->Array.toSorted((a, b) =>
+  ["c", "a", "b"]->Array.toSorted((_a, _b) =>
     %todo("This needs a comparator function. Use `String.compare` for strings, etc.")
   )
-let sortInPlace2 = Array.toSorted(["c", "a", "b"], (a, b) =>
+let sortInPlace2 = Array.toSorted(["c", "a", "b"], (_a, _b) =>
   %todo("This needs a comparator function. Use `String.compare` for strings, etc.")
 )
 

tests/tools_tests/src/expected/StdlibMigration_JSON_Stdlib.res.expected

@@ -1,15 +1,15 @@
-let p1 = JSON.parseExn("{}", ~reviver=(k, v) => v)
-let p2 = JSON.parseExnWithReviver("{}", (k, v) => v)
+let p1 = JSON.parseExn("{}", ~reviver=(_k, v) => v)
+let p2 = JSON.parseExnWithReviver("{}", (_k, v) => v)
 
 let s1 = JSON.stringifyWithIndent(JSON.Object(dict{}), 2)
-let s2 = JSON.stringifyWithReplacer(JSON.Number(1.), (k, v) => v)
-let s3 = JSON.stringifyWithReplacerAndIndent(JSON.Boolean(true), (k, v) => v, 2)
+let s2 = JSON.stringifyWithReplacer(JSON.Number(1.), (_k, v) => v)
+let s3 = JSON.stringifyWithReplacerAndIndent(JSON.Boolean(true), (_k, v) => v, 2)
 let s4 = JSON.stringifyWithFilter(JSON.Array([JSON.Number(1.)]), ["a"])
 let s5 = JSON.stringifyWithFilterAndIndent(JSON.Array([JSON.Number(1.)]), ["a"], 2)
 
 let a1 = JSON.stringifyAnyWithIndent(1, 2)
-let a2 = JSON.stringifyAnyWithReplacer(1, (k, v) => v)
-let a3 = JSON.stringifyAnyWithReplacerAndIndent(1, (k, v) => v, 2)
+let a2 = JSON.stringifyAnyWithReplacer(1, (_k, v) => v)
+let a3 = JSON.stringifyAnyWithReplacerAndIndent(1, (_k, v) => v, 2)
 let a4 = JSON.stringifyAnyWithFilter(1, ["a"])
 let a5 = JSON.stringifyAnyWithFilterAndIndent(1, ["a"], 2)
 

tests/tools_tests/src/expected/StdlibMigration_Promise2.res.expected

@@ -1,5 +1,5 @@
 let p1 = Promise.resolve(1)
-let p2 = Promise.reject(Failure("err"))
+let _p2 = Promise.reject(Failure("err"))
 
 let all1 = Promise.all([Promise.resolve(1), Promise.resolve(2)])
 let all2 = Promise.all2((Promise.resolve(1), Promise.resolve(2)))
@@ -37,7 +37,7 @@ external p2: promise<int> = "p2"
 
 let catchPipe = Promise.resolve(1)->Promise.catch(_e => Promise.resolve(0))
 let catchDirect = Promise.catch(Promise.resolve(1), _e => Promise.resolve(0))
-let make1 = Promise.make((resolve, reject) => resolve(1))
+let make1 = Promise.make((resolve, _) => resolve(1))
 
 let _ = p2->Promise.then(x => Promise.resolve(x + 1))
 

tests/tools_tests/src/expected/StdlibMigration_TypedArray_Stdlib.res.expected

@@ -1,4 +1,4 @@
 let a = Uint8Array.fromBuffer(ArrayBuffer.make(8), ~byteOffset=2)
 let b = Uint8Array.fromBuffer(ArrayBuffer.make(8), ~byteOffset=2, ~length=2)
-let c = Uint8Array.fromArrayLikeOrIterable([1, 2], ~map=(v, i) => v)
+let c = Uint8Array.fromArrayLikeOrIterable([1, 2], ~map=(v, _i) => v)
 

tests/tools_tests/src/migrate/OptionalArgRename.res

@@ -1,7 +1,11 @@
 module Target = {
-  let doStuff = (~newName: option<int>=?) => ()
+  let doStuff = (~newName: option<int>=?) => {
+    ignore(newName)
+  }
 }
 
+let _ = Target.doStuff
+
 external doStuff: (~oldName: option<int>=?) => unit = "doStuff"
 
 /* Intentionally no usage here; this test exercises migration config parsing and ensures optional label rename is preserved and doesn’t crash. */

tests/tools_tests/src/migrate/StdlibMigration_JSON_Stdlib.res

@@ -1,14 +1,14 @@
-let p1 = JSON.parseExn("{}", ~reviver=(k, v) => v)
-let p2 = JSON.parseExnWithReviver("{}", (k, v) => v)
+let p1 = JSON.parseExn("{}", ~reviver=(_k, v) => v)
+let p2 = JSON.parseExnWithReviver("{}", (_k, v) => v)
 
 let s1 = JSON.stringifyWithIndent(JSON.Object(dict{}), 2)
-let s2 = JSON.stringifyWithReplacer(JSON.Number(1.), (k, v) => v)
-let s3 = JSON.stringifyWithReplacerAndIndent(JSON.Boolean(true), (k, v) => v, 2)
+let s2 = JSON.stringifyWithReplacer(JSON.Number(1.), (_k, v) => v)
+let s3 = JSON.stringifyWithReplacerAndIndent(JSON.Boolean(true), (_k, v) => v, 2)
 let s4 = JSON.stringifyWithFilter(JSON.Array([JSON.Number(1.)]), ["a"])
 let s5 = JSON.stringifyWithFilterAndIndent(JSON.Array([JSON.Number(1.)]), ["a"], 2)
 
 let a1 = JSON.stringifyAnyWithIndent(1, 2)
-let a2 = JSON.stringifyAnyWithReplacer(1, (k, v) => v)
-let a3 = JSON.stringifyAnyWithReplacerAndIndent(1, (k, v) => v, 2)
+let a2 = JSON.stringifyAnyWithReplacer(1, (_k, v) => v)
+let a3 = JSON.stringifyAnyWithReplacerAndIndent(1, (_k, v) => v, 2)
 let a4 = JSON.stringifyAnyWithFilter(1, ["a"])
 let a5 = JSON.stringifyAnyWithFilterAndIndent(1, ["a"], 2)

tests/tools_tests/src/migrate/StdlibMigration_Promise2.res

@@ -1,5 +1,5 @@
 let p1 = Js.Promise2.resolve(1)
-let p2 = Js.Promise2.reject(Failure("err"))
+let _p2 = Js.Promise2.reject(Failure("err"))
 
 let all1 = Js.Promise2.all([Js.Promise2.resolve(1), Js.Promise2.resolve(2)])
 let all2 = Js.Promise2.all2((Js.Promise2.resolve(1), Js.Promise2.resolve(2)))
@@ -41,6 +41,6 @@ external p2: Js.Promise2.t<int> = "p2"
 
 let catchPipe = Js.Promise2.resolve(1)->Js.Promise2.catch(_e => Js.Promise2.resolve(0))
 let catchDirect = Js.Promise2.catch(Js.Promise2.resolve(1), _e => Js.Promise2.resolve(0))
-let make1 = Js.Promise2.make((~resolve, ~reject) => resolve(1))
+let make1 = Js.Promise2.make((~resolve, ~reject as _) => resolve(1))
 
 let _ = p2->Js.Promise2.then(x => Js.Promise2.resolve(x + 1))

tests/tools_tests/src/migrate/StdlibMigration_TypedArray_Stdlib.res

@@ -1,3 +1,3 @@
 let a = Uint8Array.fromBufferToEnd(ArrayBuffer.make(8), ~byteOffset=2)
 let b = Uint8Array.fromBufferWithRange(ArrayBuffer.make(8), ~byteOffset=2, ~length=2)
-let c = Uint8Array.fromArrayLikeOrIterableWithMap([1, 2], (v, i) => v)
+let c = Uint8Array.fromArrayLikeOrIterableWithMap([1, 2], (v, _i) => v)