Review

Author: fhammerschmidt

packages/dev-playground/src/Main.res

@@ -832,23 +832,20 @@ module App = {
       }
 
       let share = async () => {
-        try {
-          let _ = await UrlState.copyUrlState(
-            Signal.peek(source),
-            Signal.peek(compilerVersion),
-            Signal.peek(moduleSystem),
-            Signal.peek(warnFlags),
-            Signal.peek(jsxPreserveMode),
-            Signal.peek(experimentalFeatures),
-          )
-          showToast("Link copied")
-        } catch {
-        | JsExn(_) => showToast("Could not copy link")
-        | _ => showToast("Could not copy link")
+        switch await UrlState.copyUrlState(
+          Signal.peek(source),
+          Signal.peek(compilerVersion),
+          Signal.peek(moduleSystem),
+          Signal.peek(warnFlags),
+          Signal.peek(jsxPreserveMode),
+          Signal.peek(experimentalFeatures),
+        ) {
+        | Ok() => showToast("Link copied")
+        | Error(message) => showToast(message)
         }
       }
 
-      share()->ignore
+      share()->Promise.ignore
     }
 
     let loadCompiler = (version, compileAfterLoad) => {

packages/dev-playground/src/UrlState.res

@@ -241,19 +241,28 @@ let copyUrlState = async (
   warnFlags,
   jsxPreserveMode,
   experimentalFeatures,
-) => {
-  replaceSequence := replaceSequence.contents + 1
-  let encoded = await encodeCode(source)
-  applyUrlState(
-    encoded,
-    compilerVersion,
-    moduleSystem,
-    warnFlags,
-    jsxPreserveMode,
-    experimentalFeatures,
-  )
+): result<unit, string> => {
+  try {
+    replaceSequence := replaceSequence.contents + 1
+    let sequence = replaceSequence.contents
+    let encoded = await encodeCode(source)
+    if sequence === replaceSequence.contents {
+      applyUrlState(
+        encoded,
+        compilerVersion,
+        moduleSystem,
+        warnFlags,
+        jsxPreserveMode,
+        experimentalFeatures,
+      )
 
-  let href = windowHref()
-  let _ = await copyText(href)
-  href
+      let href = windowHref()
+      let _ = await copyText(href)
+      Ok()
+    } else {
+      Error("Link changed before it could be copied")
+    }
+  } catch {
+  | _ => Error("Could not copy link")
+  }
 }