Use a single vendored @rescript/react package across the repo#7525
Merged
cknitt merged 3 commits intorescript-lang:masterfrom Apr 28, 2026
Merged
Use a single vendored @rescript/react package across the repo#7525cknitt merged 3 commits intorescript-lang:masterfrom
cknitt merged 3 commits intorescript-lang:masterfrom
Conversation
cknitt
changed the title
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
Author
|
@zth Do you have any idea what may be causing the changes in the analysis test output? |
cknitt
force-pushed
the
packages-react
branch
3 times, most recently
from
830b759 to
ab2bca5
Compare
cknitt
force-pushed
the
packages-react
branch
2 times, most recently
from
355099a to
c710b5f
Compare
cknitt
force-pushed
the
packages-react
branch
2 times, most recently
from
c928dc0 to
955c01a
Compare
cknitt
force-pushed
the
packages-react
branch
3 times, most recently
from
c57fe8b to
37478e5
Compare
cknitt
force-pushed
the
packages-react
branch
from
37478e5 to
b2f16c0
Compare
cknitt
force-pushed
the
packages-react
branch
from
b2f16c0 to
915d15c
Compare
cknitt
changed the title
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bbc3a70a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tsnobip
approved these changes
Apr 28, 2026
# Conflicts: # analysis/examples/larger-project/package.json
fhammerschmidt
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add latest
@rescript/reacttotests/dependencies/rescript-reactand the yarn workspace and use it in tests, analysis tests, tools_tests, gentype_tests.This is not meant to replace the separate repo https://github.com/rescript-lang/rescript-react though, we'd still do @rescript/react releases from there to be able to release versions independently from compiler versions.
There was already a copy intests/dependencies, too, but I think the location underpackagesis more prominent.