Separate line and block comments into distinct node types#271
Merged
aspeddro merged 3 commits intorescript-lang:mainfrom Apr 24, 2026
Merged
Separate line and block comments into distinct node types#271aspeddro merged 3 commits intorescript-lang:mainfrom
aspeddro merged 3 commits intorescript-lang:mainfrom
Conversation
Replace the single `comment` external token (and the `_newline_and_comment` hack) with two distinct node types: `line_comment` (a grammar-level token matching `//...`) and `block_comment` (handled by the external scanner). This makes comment node types more precise and removes the workaround of aliasing `_newline_and_comment` as `comment` in statement delimiters. Update all query files and corpus tests to reference the new node names.
nojaf
approved these changes
Apr 24, 2026
cristianoc
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single
commentexternal token (and the_newline_and_commenthack) with two distinct node types:
line_comment(a grammar-level tokenmatching
//...) andblock_comment(handled by the external scanner).This makes comment node types more precise and removes the workaround of aliasing
_newline_and_commentascommentin statement delimiters. Update all query files and corpus tests to reference the new node names.Close #135
Co-authored-by: Claude Opus 4.7 noreply@anthropic.com
🤖 Generated with Claude Code