Skip to content

Commit 2f4c8de

Browse files
committed
fix: mypy type errors in contact imports
1 parent 6880d7c commit 2f4c8de

3 files changed

Lines changed: 9 additions & 5 deletions

File tree

examples/with_custom_http_client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ def request(
2121
url: str,
2222
headers: Mapping[str, str],
2323
json: Optional[Union[Dict[str, Any], List[Any]]] = None,
24+
files: Optional[Dict[str, Any]] = None,
25+
data: Optional[Dict[str, str]] = None,
2426
) -> Tuple[bytes, int, Dict[str, str]]:
2527
print(f"[HTTP] {method.upper()} {url} with timeout={self.timeout}")
2628
try:

resend/contacts/imports/_contact_imports.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,10 @@ def create(cls, params: CreateParams) -> CreateContactImportResponse:
108108
if "column_map" in params:
109109
form_data["column_map"] = json_lib.dumps(params["column_map"])
110110
if "on_conflict" in params:
111-
form_data["on_conflict"] = params["on_conflict"] # type: ignore[assignment]
111+
form_data["on_conflict"] = params["on_conflict"]
112112
if "segments" in params:
113113
form_data["segments"] = json_lib.dumps(
114-
[{"id": sid} for sid in params["segments"]] # type: ignore[union-attr]
114+
[{"id": sid} for sid in params["segments"]]
115115
)
116116

117117
resp = request.Request[ContactImports.CreateContactImportResponse](
@@ -194,10 +194,10 @@ async def create_async(cls, params: CreateParams) -> CreateContactImportResponse
194194
if "column_map" in params:
195195
form_data["column_map"] = json_lib.dumps(params["column_map"])
196196
if "on_conflict" in params:
197-
form_data["on_conflict"] = params["on_conflict"] # type: ignore[assignment]
197+
form_data["on_conflict"] = params["on_conflict"]
198198
if "segments" in params:
199199
form_data["segments"] = json_lib.dumps(
200-
[{"id": sid} for sid in params["segments"]] # type: ignore[union-attr]
200+
[{"id": sid} for sid in params["segments"]]
201201
)
202202

203203
resp = await AsyncRequest[ContactImports.CreateContactImportResponse](

tests/contact_imports_test.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ def test_get_contact_import(self) -> None:
6060
)
6161
assert result["id"] == "479e3145-dd38-476b-932c-529ceb705947"
6262
assert result["status"] == "completed"
63-
assert result["counts"]["total"] == 100
63+
counts = result["counts"]
64+
assert counts is not None
65+
assert counts["total"] == 100
6466

6567
def test_get_contact_import_missing_id(self) -> None:
6668
try:

0 commit comments

Comments
 (0)