fix: use NotRequired for counts, remove duplicate status param, guard files/data kwargs

Author: drish

resend/async_request.py

@@ -101,14 +101,18 @@ async def make_request(self, url: str) -> Union[Dict[str, Any], List[Any]]:
                     suggested_action="Run: pip install resend[async]",
                 )
 
-            content, _status_code, resp_headers = await async_client.request(
-                method=self.verb,
-                url=url,
-                headers=headers,
-                json=json_params,
-                files=self.files,
-                data=self.data,
-            )
+            kwargs: Dict[str, Any] = {
+                "method": self.verb,
+                "url": url,
+                "headers": headers,
+                "json": json_params,
+            }
+            if self.files is not None:
+                kwargs["files"] = self.files
+            if self.data is not None:
+                kwargs["data"] = self.data
+
+            content, _status_code, resp_headers = await async_client.request(**kwargs)
 
         # Safety net around the HTTP Client
         except ResendError:

resend/contacts/imports/_contact_import.py

@@ -1,4 +1,4 @@
-from typing import Optional
+from typing_extensions import NotRequired
 
 from resend._base_response import BaseResponse
 
@@ -38,4 +38,4 @@ class ContactImport(BaseResponse):
     id: str
     status: str
     created_at: str
-    counts: Optional[ContactImportCounts]
+    counts: NotRequired[ContactImportCounts]

resend/contacts/imports/_contact_imports.py

@@ -166,11 +166,6 @@ def list(cls, params: Optional[ListParams] = None) -> ListContactImportsResponse
         """
         query_params = cast(Dict[Any, Any], params) if params else None
         path = PaginationHelper.build_paginated_path("/contacts/imports", query_params)
-        # Append status filter if provided (PaginationHelper only handles limit/after/before)
-        if params and "status" in params:
-            separator = "&" if "?" in path else "?"
-            path = f"{path}{separator}status={params['status']}"
-
         resp = request.Request[ContactImports.ListContactImportsResponse](
             path=path,
             params={},
@@ -254,10 +249,6 @@ async def list_async(cls, params: Optional[ListParams] = None) -> ListContactImp
         """
         query_params = cast(Dict[Any, Any], params) if params else None
         path = PaginationHelper.build_paginated_path("/contacts/imports", query_params)
-        if params and "status" in params:
-            separator = "&" if "?" in path else "?"
-            path = f"{path}{separator}status={params['status']}"
-
         resp = await AsyncRequest[ContactImports.ListContactImportsResponse](
             path=path,
             params={},

resend/request.py

@@ -88,14 +88,18 @@ def make_request(self, url: str) -> Union[Dict[str, Any], List[Any]]:
 
             sync_client = cast(HTTPClient, resend.default_http_client)
 
-            content, _status_code, resp_headers = sync_client.request(
-                method=self.verb,
-                url=url,
-                headers=headers,
-                json=json_params,
-                files=self.files,
-                data=self.data,
-            )
+            kwargs: Dict[str, Any] = {
+                "method": self.verb,
+                "url": url,
+                "headers": headers,
+                "json": json_params,
+            }
+            if self.files is not None:
+                kwargs["files"] = self.files
+            if self.data is not None:
+                kwargs["data"] = self.data
+
+            content, _status_code, resp_headers = sync_client.request(**kwargs)
 
         # Safety net around the HTTP Client
         except Exception as e: