Small refactoring

Author: reshke

src/backend/access/aocs/aocsam.c

@@ -120,8 +120,6 @@ open_all_datumstreamread_segfiles(Relation rel,
 	{
 		AttrNumber	attno = proj_atts[i];
 
-		RelationOpenSmgr(rel);
-
 		open_datumstreamread_segfile(basepath, rel->rd_smgr->smgr_ao, rel->rd_node, segInfo, ds[attno], attno);
 		datumstreamread_block(ds[attno], blockDirectory, attno);
 	}
@@ -1420,8 +1418,6 @@ openFetchSegmentFile(AOCSFetchDesc aocsFetchDesc,
 	if (logicalEof == 0)
 		return false;
 
-	RelationOpenSmgr(aocsFetchDesc->relation);
-
 	open_datumstreamread_segfile(aocsFetchDesc->basepath, aocsFetchDesc->relation->rd_smgr->smgr_ao, aocsFetchDesc->relation->rd_node,
 								 fsInfo,
 								 datumStreamFetchDesc->datumStream,

src/backend/access/appendonly/appendonlyam.c

@@ -289,7 +289,6 @@ SetNextFileSegForRead(AppendOnlyScanDesc scan)
 	Assert(scan->initedStorageRoutines);
 
 
-	RelationOpenSmgr(reln);
 	AppendOnlyStorageRead_OpenFile(
 								   &scan->storageRead,
 								   scan->aos_filenamepath,

src/backend/cdb/cdbappendonlystorageread.c

@@ -320,6 +320,7 @@ AppendOnlyStorageRead_OpenFile(AppendOnlyStorageRead *storageRead,
 	Assert(storageRead != NULL);
 	Assert(storageRead->isActive);
 	Assert(filePathName != NULL);
+	Assert(storageRead->smgrAO);
 
 	/*
 	 * The EOF must be greater than 0, otherwise we risk transactionally