force key encoding to binary to avoid UTF-8 issues#96
Open
aaronpk wants to merge 4 commits into
Open
Conversation
Author
|
Okay well it looks like my fix fails in ruby 1.9.3 and below for various reasons. Any better suggestions? |
This fixes the frozen string issue from before. Ruby 1.8.7 doesn't support string encoding, so just skip this fanciness for that version. Updates the tests to demonstrate setting a key with invalid UTF-8 chars, getting a list of the keys (including the invalid string) and retrieving the data at those keys.
Author
|
Okay I fixed this for all versions except 1.8.7 which doesn't have the concept of string encodings, so doesn't need fixing. I added a test case demonstrating how it failed in the first place. |
Contributor
|
@aaronpk I know this is an old once, but could you rebase on master so the latest tests run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow I ended up with keys in redis that contained invalid UTF-8 characters, which is now causing problems trying to retrieve them.
My code is currently failing with this stacktrace:
pointing to the source of the problem being the
.submethod of the key name.I was able to get around this issue by forcing the string encoding to binary, which still successfully removes the namespace prefix from the keys.