Skip to content

Commit f88f808

Browse files
authored
Merge pull request #574 from Shopify/extract-rufus-callable
factor out recurring enqueue block
2 parents bac8852 + a9a2883 commit f88f808

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

.rubocop_todo.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Metrics/MethodLength:
3939
# Offense count: 2
4040
# Configuration parameters: CountComments.
4141
Metrics/ModuleLength:
42-
Max: 314
42+
Max: 317
4343

4444
# Offense count: 1
4545
Style/CaseEquality:

lib/resque/scheduler.rb

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,7 @@ def load_schedule_job(name, config)
141141
args = [args, nil, job: true] if args.is_a?(::String)
142142

143143
job = rufus_scheduler.send(interval_type, *args) do
144-
if master?
145-
log! "queueing #{config['class']} (#{name})"
146-
Resque.last_enqueued_at(name, Time.now.to_s)
147-
enqueue(config)
148-
end
144+
enqueue_recurring(name, config)
149145
end
150146
@scheduled_jobs[name] = job
151147
interval_defined = true
@@ -417,6 +413,14 @@ def logger
417413

418414
private
419415

416+
def enqueue_recurring(name, config)
417+
if master?
418+
log! "queueing #{config['class']} (#{name})"
419+
Resque.last_enqueued_at(name, Time.now.to_s)
420+
enqueue(config)
421+
end
422+
end
423+
420424
def app_str
421425
app_name ? "[#{app_name}]" : ''
422426
end

0 commit comments

Comments
 (0)