From b139a60703048ed5a9d34fa09b7dc741597ba0cf Mon Sep 17 00:00:00 2001 From: Paul W <167196940+top-sigrid@users.noreply.github.com> Date: Thu, 25 Dec 2025 13:59:59 +0100 Subject: [PATCH 1/2] Fix test failig in Ruby 2.4 --- test/scheduler_hooks_test.rb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/test/scheduler_hooks_test.rb b/test/scheduler_hooks_test.rb index 532f1948..76592c49 100644 --- a/test/scheduler_hooks_test.rb +++ b/test/scheduler_hooks_test.rb @@ -36,18 +36,20 @@ def enqueued test 'before_schedule hook that does not return false should be enqueued' do enqueue_time = Time.now + 1 - SomeRealClass.expects(:before_schedule_example).with(:foo) - SomeRealClass.expects(:after_schedule_example).with(:foo) - Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, :foo) + # Use string 'foo' since JSON serialization converts symbols to strings + SomeRealClass.expects(:before_schedule_example).with('foo') + SomeRealClass.expects(:after_schedule_example).with('foo') + Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, 'foo') assert_equal(1, Resque.delayed_timestamp_size(enqueue_time.to_i), 'job should be enqueued') end test 'before_schedule hook that returns false should not be enqueued' do enqueue_time = Time.now + 1 - SomeRealClass.expects(:before_schedule_example).with(:foo).returns(false) + # Use string 'foo' since JSON serialization converts symbols to strings + SomeRealClass.expects(:before_schedule_example).with('foo').returns(false) SomeRealClass.expects(:after_schedule_example).never - Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, :foo) + Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, 'foo') assert_equal(0, Resque.delayed_timestamp_size(enqueue_time.to_i), 'job should not be enqueued') end From 8d5b47e473fc676f33e07525ad3060a477d733bf Mon Sep 17 00:00:00 2001 From: Paul W <167196940+top-sigrid@users.noreply.github.com> Date: Thu, 25 Dec 2025 14:02:37 +0100 Subject: [PATCH 2/2] remove comments --- test/scheduler_hooks_test.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/scheduler_hooks_test.rb b/test/scheduler_hooks_test.rb index 76592c49..89a8947b 100644 --- a/test/scheduler_hooks_test.rb +++ b/test/scheduler_hooks_test.rb @@ -36,7 +36,6 @@ def enqueued test 'before_schedule hook that does not return false should be enqueued' do enqueue_time = Time.now + 1 - # Use string 'foo' since JSON serialization converts symbols to strings SomeRealClass.expects(:before_schedule_example).with('foo') SomeRealClass.expects(:after_schedule_example).with('foo') Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, 'foo') @@ -46,7 +45,6 @@ def enqueued test 'before_schedule hook that returns false should not be enqueued' do enqueue_time = Time.now + 1 - # Use string 'foo' since JSON serialization converts symbols to strings SomeRealClass.expects(:before_schedule_example).with('foo').returns(false) SomeRealClass.expects(:after_schedule_example).never Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, 'foo')