Fix schedule hooks firing when timestamp <= now#817
Open
top-sigrid wants to merge 1 commit into
Open
Conversation
Member
|
@top-sigrid I think this is fine to merge, but it could use a rebase. Mind rebasing on master, pushing it up and let's see if CI passes. |
Contributor
Author
|
Hi Patrick, thanks for getting back to this! I can definitely do that, will find the time very soon. Probably a good idea to do this for my other PRs aswell :) |
Member
|
@top-sigrid oh yeah actually you're right there are a few that we can probably merge in once they are rebased. I'm aiming to get a few resque releases out around mid-month. If we can get them in before that they'll make the release. Holler when you want me to check them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
enqueue_atis called with a timestamp in the past or equal to now, the job bypasses the delayed queue and goes directly to the work queue. Previously,before_scheduleandafter_schedulehooks were incorrectly called in this case.This fix moves
process_schedule_hooksinside theelsebranch so hooks only fire when jobs actually enter the delayed queue.Fixes #816