Skip to content

Fixes #244#247

Closed
barbich wants to merge 3 commits into
rest-sh:mainfrom
barbich:barbich_feature_244
Closed

Fixes #244#247
barbich wants to merge 3 commits into
rest-sh:mainfrom
barbich:barbich_feature_244

Conversation

@barbich
Copy link
Copy Markdown

@barbich barbich commented Mar 28, 2024

refactor(cli/links): update ParseLinks method signatures to include base URL

Copy link
Copy Markdown
Contributor

@aiven-amartin aiven-amartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! A motivational test/readme change should probably pair with this change.

Also I see you updating a bunch of imports to point to your fork. That is not something we would want to merge here.

@danielgtaylor
Copy link
Copy Markdown
Collaborator

danielgtaylor commented May 27, 2026

Thanks for the PR. I'm doing a v2.0.0 cleanup pass, and this change has effectively been superseded by the v2 rewrite.

The old PR targets v1 files such as cli/links.go, while v2's hypermedia parser interface now lives under internal/hypermedia and already receives a response URL context:

ParseLinks(baseURL *url.URL, header http.Header, body any) []Link

I also closed #244 as implemented in v2 after verifying the current link parser path with:

go test ./internal/hypermedia ./internal/cli -run 'TestLinkHeaderRelativeResolution|TestNormalizeHTTPResponseDefersBodyLinkParsers'

I'm closing this PR as obsolete/superseded by v2. Please give v2.0.0 a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants