Pass along stderr from failed external auth helper invocations#327
Closed
benweint wants to merge 1 commit into
Closed
Pass along stderr from failed external auth helper invocations#327benweint wants to merge 1 commit into
benweint wants to merge 1 commit into
Conversation
9838ca0 to
a428b89
Compare
Collaborator
|
Thanks for the PR. I re-checked this against v2.0.0, and failed external-tool auth now includes a bounded stderr excerpt in the error message. I verified the focused external-tool auth tests before closing; the v2 path reports errors in the shape: This v1-era patch is superseded by the v2 implementation, so I’m closing it out. Thanks again for pushing on the debugging experience here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change passes along the stderr from an external auth helper, if the helper exits with a non-zero exit status. It also makes the message reported for external auth tool invocation failures more descriptive.
Today, when an external auth helper exits with a non-zero exit code, restish shows an error like this:
With this entry in
apis.json:... attempting to use this API yields
Which notably lacks the error message produced by the external auth helper. This is obviously a contrived example, but given how finicky auth can be, those errors are often critical to debugging.
Here's how this looks after the change: