fix: gate gcp workload id cleanup#104
Merged
Merged
Conversation
lukebond
requested review from
tillrohrmann
and removed request for
tillrohrmann
release v2.3.0 introduced gcp workload identity but included a regression. if you weren't on GCP it would try to check for a CR for which the CRD was absent. in this commit we plumb through the helm conditional used for the RBAC into the runtime and use it to gate all GCP WI related steps.
lukebond
force-pushed
the
fix/gate-gcp-workload-id-cleanup
branch
from
9bd4e54 to
d31489d
Compare
tillrohrmann
approved these changes
Mar 20, 2026
tillrohrmann
left a comment
tillrohrmann
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix @lukebond. LGTM. +1 for merging :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #103
release v2.3.0 introduced gcp workload identity but included a regression. if you weren't on GCP it would try to check for a CR for which the CRD was absent, causing an error and for reconcile to fail.
in this commit we plumb through the helm conditional used for the RBAC into the runtime and use it to gate all GCP WI related steps.
whilst i had tested the last change properly, i failed to re-test after taking some PR feedback which introduced the bug (making the RBAC conditional should have been accompanied with the gating).