fix: canary base image#116
Merged
Merged
Conversation
tillrohrmann
approved these changes
Apr 8, 2026
tillrohrmann
left a comment
tillrohrmann
left a comment
Contributor
There was a problem hiding this comment.
Thanks for creating this PR @lukebond. LGTM. +1 for merging :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you used the new trusted root CA feature in the CR without choosing a different canary image then it would fail, because that base image doesn't contain certs. users can still work around it by setting an override, and anybody not using the feature would not be impacted. so this doesn't warrant a release on its own.
this PR changes the default base image for the canary pod, which is what's used for the init container also.