Deprecate random seed

Author: slinkydeveloper

sdk-common/src/main/java/dev/restate/sdk/common/InvocationId.java

@@ -9,16 +9,16 @@
 package dev.restate.sdk.common;
 
 /**
- * This represents a stable identifier created by Restate for this invocation. It can be used as
- * idempotency key when accessing external systems.
+ * This represents a stable identifier created by Restate for this invocation.
  *
  * <p>You can embed it in external system requests by using {@link #toString()}.
  */
 public interface InvocationId {
 
   /**
-   * @return a seed to be used with {@link java.util.Random}.
+   * @deprecated Just use the random provided by the context API.
    */
+  @Deprecated(forRemoval = true)
   long toRandomSeed();
 
   @Override

sdk-core/src/main/java/dev/restate/sdk/core/InvocationIdImpl.java

@@ -9,20 +9,15 @@
 package dev.restate.sdk.core;
 
 import dev.restate.sdk.common.InvocationId;
-import java.nio.charset.StandardCharsets;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
 import java.util.Objects;
-import org.jspecify.annotations.Nullable;
 
 final class InvocationIdImpl implements InvocationId {
 
   private final String id;
-  private Long seed;
+  private long seed;
 
-  InvocationIdImpl(String debugId, @Nullable Long seed) {
+  InvocationIdImpl(String debugId, long seed) {
     this.id = debugId;
-    // If random seed null, it will be computed
     this.seed = seed;
   }
 
@@ -41,28 +36,6 @@ public int hashCode() {
 
   @Override
   public long toRandomSeed() {
-    if (seed == null) {
-      // Hash the seed to SHA-256 to increase entropy
-      MessageDigest md;
-      try {
-        md = MessageDigest.getInstance("SHA-256");
-      } catch (NoSuchAlgorithmException e) {
-        throw new RuntimeException(e);
-      }
-      byte[] digest = md.digest(id.getBytes(StandardCharsets.UTF_8));
-
-      // Generate the long
-      long n = 0;
-      n |= ((long) (digest[7] & 0xFF) << (Byte.SIZE * 7));
-      n |= ((long) (digest[6] & 0xFF) << (Byte.SIZE * 6));
-      n |= ((long) (digest[5] & 0xFF) << (Byte.SIZE * 5));
-      n |= ((long) (digest[4] & 0xFF) << (Byte.SIZE * 4));
-      n |= ((long) (digest[3] & 0xFF) << (Byte.SIZE * 3));
-      n |= ((digest[2] & 0xFF) << (Byte.SIZE * 2));
-      n |= ((digest[1] & 0xFF) << Byte.SIZE);
-      n |= (digest[0] & 0xFF);
-      seed = n;
-    }
     return seed;
   }