Test TerminalError.metadata (#598)

Author: slinkydeveloper

.github/workflows/integration.yaml

@@ -135,7 +135,7 @@ jobs:
 
       - name: Run test tool
         continue-on-error: ${{ inputs.continueOnError == 'true' }}
-        uses: restatedev/sdk-test-suite@v3.4
+        uses: restatedev/sdk-test-suite@v4.0
         with:
           envVars: ${{ inputs.envVars }}
           testArtifactOutput: ${{ inputs.testArtifactOutput != '' && inputs.testArtifactOutput || 'sdk-java-integration-test-report' }}

test-services/src/main/kotlin/dev/restate/sdk/testservices/FailingImpl.kt

@@ -25,18 +25,18 @@ class FailingImpl : Failing {
   private val eventualSuccessSideEffectCalls = AtomicInteger(0)
   private val eventualFailureSideEffectCalls = AtomicInteger(0)
 
-  override suspend fun terminallyFailingCall(errorMessage: String) {
+  override suspend fun terminallyFailingCall(failureToPropagate: Failing.FailureToPropagate) {
     LOG.info("Invoked fail")
 
-    throw TerminalException(errorMessage)
+    throw TerminalException(failureToPropagate.errorMessage, failureToPropagate.metadata)
   }
 
   override suspend fun callTerminallyFailingCall(
-      errorMessage: String,
+      failureToPropagate: Failing.FailureToPropagate,
   ): String {
     LOG.info("Invoked failAndHandle")
 
-    virtualObject<Failing>(random().nextUUID().toString()).terminallyFailingCall(errorMessage)
+    virtualObject<Failing>(random().nextUUID().toString()).terminallyFailingCall(failureToPropagate)
 
     throw IllegalStateException("This should be unreachable")
   }
@@ -52,8 +52,10 @@ class FailingImpl : Failing {
     }
   }
 
-  override suspend fun terminallyFailingSideEffect(errorMessage: String) {
-    runBlock<Unit> { throw TerminalException(errorMessage) }
+  override suspend fun terminallyFailingSideEffect(failureToPropagate: Failing.FailureToPropagate) {
+    runBlock<Unit> {
+      throw TerminalException(failureToPropagate.errorMessage, failureToPropagate.metadata)
+    }
 
     throw IllegalStateException("Should not be reached.")
   }

test-services/src/main/kotlin/dev/restate/sdk/testservices/contracts/Failing.kt

@@ -9,18 +9,21 @@
 package dev.restate.sdk.testservices.contracts
 
 import dev.restate.sdk.annotation.*
-import dev.restate.sdk.kotlin.*
+import kotlinx.serialization.Serializable
 
 @VirtualObject
 @Name("Failing")
 interface Failing {
-  @Handler suspend fun terminallyFailingCall(errorMessage: String)
+  @Serializable
+  data class FailureToPropagate(val errorMessage: String, val metadata: Map<String, String>? = null)
 
-  @Handler suspend fun callTerminallyFailingCall(errorMessage: String): String
+  @Handler suspend fun terminallyFailingCall(failureToPropagate: FailureToPropagate)
+
+  @Handler suspend fun callTerminallyFailingCall(failureToPropagate: FailureToPropagate): String
 
   @Handler suspend fun failingCallWithEventualSuccess(): Int
 
-  @Handler suspend fun terminallyFailingSideEffect(errorMessage: String)
+  @Handler suspend fun terminallyFailingSideEffect(failureToPropagate: FailureToPropagate)
 
   /**
    * `minimumAttempts` should be used to check when to succeed. The retry policy should be