Skip to content

Clarify max attempts meaning #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slinkydeveloper merged 1 commit into from
Sep 11, 2025
Merged

Clarify max attempts meaning #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/RetryPolicy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ data class RetryPolicy(
/** Maximum delay between retries. */
val maxDelay: Duration? = null,
/**
* Maximum number of attempts before giving up retrying.
* Maximum number of attempts, including the initial, before giving up retrying.
*
* The policy gives up retrying when either at least the given number of attempts is reached, or
* the [maxDuration] (if set) is reached first. If both [maxAttempts] and [maxDuration] are
Expand Down
2 changes: 1 addition & 1 deletion sdk-common/src/main/java/dev/restate/sdk/common/RetryPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public RetryPolicy setMaxDelay(@Nullable Duration maxDelay) {
}

/**
* Maximum number of attempts before giving up retrying.
* Maximum number of attempts, including the initial, before giving up retrying.
*
* <p>The policy gives up retrying when either at least the given number of attempts is reached,
* or the {@code maxDuration} specified with {@link #setMaxDuration(Duration)} (if set) is reached
Expand Down