Skip to content

Allow passing custom fetch implementation to client#765

Open
n-siddarth wants to merge 4 commits into
restatedev:mainfrom
n-siddarth:n-siddarth/custom-fetch
Open

Allow passing custom fetch implementation to client#765
n-siddarth wants to merge 4 commits into
restatedev:mainfrom
n-siddarth:n-siddarth/custom-fetch

Conversation

@n-siddarth

Copy link
Copy Markdown

Fixes #764

@slinkydeveloper slinkydeveloper left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you. can you just improve the tsdoc a bit to explain why you would provide a different fetch client?

journalValueCodec?: JournalValueCodec;

/**
* Custom fetch handler

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Custom fetch handler
* Custom fetch client. This allows you to provide a different fetch implementation.

@n-siddarth

Copy link
Copy Markdown
Author

Sure, will do that later today 👍

@n-siddarth

Copy link
Copy Markdown
Author

@slinkydeveloper Is this better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow specifying custom fetch implementation in client

2 participants