Python 2 to 3#179
Closed
gabor-boros wants to merge 8 commits into
Closed
Conversation
Member
Author
|
Issues
======
+ Solved 189
- Added 118
Coverage increased per file
===========================
+ rethinkdb/tornado_net/net_tornado.py 1
+ rethinkdb/errors.py 1
Coverage decreased per file
===========================
- rethinkdb/_dump.py -1
- rethinkdb/net.py -1
- rethinkdb/_export.py -1
- rethinkdb/_index_rebuild.py -1
Clones added
============
- rethinkdb/asyncio_net/net_asyncio.py 1
- rethinkdb/_dump.py 1
- rethinkdb/_export.py 1
- rethinkdb/trio_net/net_trio.py 1
- rethinkdb/ast.py 2
See the complete overview on Codacy |
* Upgrade @asyncio.coroutine to async * 🚧 2 tests do not pass yet * 🚧 1 test error (nursery not found WTF) and 1 failing but don't know why..yet * Remove commented code * Use ImportError instead of Exception Co-authored-by: lsabi <luca.sabiucciu@gmail.com> Co-authored-by: Boros Gábor <gabor.brs@gmail.com>
Import ABC from collections.abc for Python 3.
… into python-2-to-3
|
wait, the package was not python3-ready? why was that not excluded in the |
|
@gabor-boros could you change |
Member
Author
|
@ShadowJonathan The package is already python 3 compatible. This PR is about to make it Python 3 only. Whenever the PR is in that state, I'll make sure that setup.py has the right required python version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for the change
#168
Description
Make the code Python 3.6+ compatible (and drop python2 support)