Skip to content

Commit 6a52a43

Browse files
TheTomclaude
andcommitted
fix: TURBO_D=128 independent of QK_TURBO3, file turbo4 bugs PrismML-Eng#29
Codex post-commit review found: 1. TURBO_D was QK_TURBO3 (now 32) — broke turbo4 C array sizes 2. SET_ROWS kernel turbo3-specific but instantiated for turbo4 3. Tail block drop for non-128 head dims Fixed PrismML-Eng#3 (TURBO_D). Mintplex-Labs#1 and Mintplex-Labs#2 don't affect turbo3+dk128 path. Co-Authored-By: tturney@psyguard.ai Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent fff2092 commit 6a52a43

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

ggml/src/ggml-turbo-quant.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
#define TURBO_SEED_ROTATION 42
2121
#define TURBO_SEED_QJL 1042
22-
#define TURBO_D QK_TURBO3 /* 128 — block size = head_dim */
22+
#define TURBO_D 128 /* rotation group size = head_dim (independent of block size) */
2323
#define TURBO_QJL_CONST 1.2533141373155003f /* sqrt(pi/2) */
2424

2525
/* Optimal centroids from paper (scaled by 1/sqrt(d)) */

0 commit comments

Comments
 (0)